Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure NKG has least privileges #1004

Merged
merged 2 commits into from
Aug 29, 2023
Merged

Conversation

sjberman
Copy link
Contributor

Problem: NKG wasn't running with the least privileges necessary, which could lead to potential security issues.

Solution: Remove unnecessary RBAC, and add security restrictions where necessary.

Closes #545

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@sjberman sjberman requested a review from a team as a code owner August 28, 2023 16:57
@github-actions github-actions bot added the bug Something isn't working label Aug 28, 2023
@sjberman sjberman changed the title Apply least privileges to NKG Ensure NKG has least privileges Aug 28, 2023
Problem: NKG wasn't running with the least privileges necessary, which could lead to potential security issues.

Solution: Remove unnecessary RBAC, and add security restrictions where necessary.
@sjberman sjberman merged commit 3ce86fb into nginxinc:main Aug 29, 2023
21 checks passed
@sjberman sjberman deleted the fix/least-privileges branch August 29, 2023 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

The NKG controller should run with least privileges
4 participants