Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Helm Chart: Add support for tolerations #1192

Merged
merged 5 commits into from
Oct 31, 2023
Merged

Helm Chart: Add support for tolerations #1192

merged 5 commits into from
Oct 31, 2023

Conversation

oWretch
Copy link
Contributor

@oWretch oWretch commented Oct 24, 2023

Proposed changes

Add support for defining tolerations in the Helm chart.

Problem: We run a separate nodepool for system services which has taints applied, and we therefore need the relevant tolerations to be applied to the pod.

Solution: Add support for tolerations to be supplied if required. If not provided, there is no change the the deployment

Testing: Validate deployment both with and without tolerations.

Closes #1196

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@oWretch oWretch requested a review from a team as a code owner October 24, 2023 23:13
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Oct 24, 2023
@kate-osborn
Copy link
Contributor

Thanks for the PR @oWretch!

Typically, we require that every PR is associated with an issue. Issues help us prioritize and refine features before working on them. Since this PR is straightforward and has a good description (very appreciated!) I went ahead and filed an issue for it: #1196. Feel free to add any missing context.

@kate-osborn kate-osborn added the enhancement New feature or request label Oct 25, 2023
@kate-osborn kate-osborn added the helm-chart Relates to helm chart label Oct 26, 2023
@kate-osborn kate-osborn merged commit febd0a9 into nginxinc:main Oct 31, 2023
23 checks passed
@oWretch oWretch deleted the f/helm-tolerations branch October 31, 2023 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request helm-chart Relates to helm chart
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Support configuring tolerations in helm chart
3 participants