Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Helm Chart: Support extra volume mounts #1193

Merged
merged 19 commits into from
Nov 1, 2023
Merged

Helm Chart: Support extra volume mounts #1193

merged 19 commits into from
Nov 1, 2023

Conversation

oWretch
Copy link
Contributor

@oWretch oWretch commented Oct 24, 2023

Proposed changes

Add support for mounting additional volumes into the containers

Problem: We leverage internal certificates for communication between services and need to load the trusted root certificate into the containers. Mounting the certificate as a volume prevents us having to build our own container image.

Solution: Allows providing additional volumes to be mounted into containers, and the volume mounts to enable different combinations to be mounted in addition to the default mounts. If none are provided there is no change in the deployment

Testing: Deploy the chart with and without additional volume mounts.

Closes #1199

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@oWretch oWretch requested a review from a team as a code owner October 24, 2023 23:31
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Oct 24, 2023
@kate-osborn
Copy link
Contributor

@oWretch I filed an issue for this PR as well and added it to the PR description: #1199.

I'll take a look at both PRs this week.

@kate-osborn kate-osborn added the enhancement New feature or request label Oct 25, 2023
deploy/helm-chart/README.md Outdated Show resolved Hide resolved
deploy/helm-chart/README.md Outdated Show resolved Hide resolved
deploy/helm-chart/values.yaml Outdated Show resolved Hide resolved
deploy/helm-chart/values.yaml Outdated Show resolved Hide resolved
deploy/helm-chart/values.yaml Outdated Show resolved Hide resolved
deploy/helm-chart/templates/deployment.yaml Outdated Show resolved Hide resolved
deploy/helm-chart/templates/deployment.yaml Outdated Show resolved Hide resolved
deploy/helm-chart/templates/deployment.yaml Outdated Show resolved Hide resolved
deploy/helm-chart/values.yaml Outdated Show resolved Hide resolved
oWretch and others added 9 commits October 26, 2023 13:16
Co-authored-by: Kate Osborn <50597707+kate-osborn@users.noreply.github.com>
Co-authored-by: Kate Osborn <50597707+kate-osborn@users.noreply.github.com>
Co-authored-by: Kate Osborn <50597707+kate-osborn@users.noreply.github.com>
Co-authored-by: Kate Osborn <50597707+kate-osborn@users.noreply.github.com>
Co-authored-by: Kate Osborn <50597707+kate-osborn@users.noreply.github.com>
Co-authored-by: Kate Osborn <50597707+kate-osborn@users.noreply.github.com>
Co-authored-by: Kate Osborn <50597707+kate-osborn@users.noreply.github.com>
Co-authored-by: Kate Osborn <50597707+kate-osborn@users.noreply.github.com>
deploy/helm-chart/README.md Outdated Show resolved Hide resolved
deploy/helm-chart/README.md Outdated Show resolved Hide resolved
@kate-osborn kate-osborn added the helm-chart Relates to helm chart label Oct 26, 2023
deploy/helm-chart/values.yaml Outdated Show resolved Hide resolved
deploy/helm-chart/values.yaml Outdated Show resolved Hide resolved
Co-authored-by: Kate Osborn <50597707+kate-osborn@users.noreply.github.com>
Co-authored-by: Kate Osborn <50597707+kate-osborn@users.noreply.github.com>
@kate-osborn kate-osborn merged commit 307db64 into nginxinc:main Nov 1, 2023
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request helm-chart Relates to helm chart
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Support extra volume mounts in helm chart
3 participants