Fix reload errors for NGINX when large num of match conditions are used #1799
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sjberman
reviewed
Apr 2, 2024
| {{- end }} | ||
| js_content httpmatches.redirect; |
There was a problem hiding this comment.
This directive shouldn't exist if there are no HTTPMatchVars
sjberman
reviewed
Apr 2, 2024
| throw Error( | ||
| `cannot redirect the request; error parsing ${r.variables[MATCHES_VARIABLE]} into a JSON object: ${e}`, | ||
| ); | ||
| while (true) { |
There was a problem hiding this comment.
Is this loop just overwriting the matches var every time? So when you look for a match, you're only looking at the last iteration.
|
opening another PR for this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Problem: A large number of match conditions for a single hostname/path cause reload errors with NGINX about being parameter being too long
Solution: The solution is to divide the
http_matchesinto different sets and then parse them through NGINX using NJS to map the correct match conditionTesting: TODO
Closes #1107
Checklist
Before creating a PR, run through this checklist and mark each as complete.
Release notes
If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.