Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support tracing via the ObservabilityPolicy #2004

Merged
merged 11 commits into from
May 29, 2024
Merged

Support tracing via the ObservabilityPolicy #2004

merged 11 commits into from
May 29, 2024

Commits on May 29, 2024

  1. Support tracing via the ObservabilityPolicy 

    Problem: As a user, I want to be able to enable tracing for requests flowing through NGF to my backend applications, so I can understand and debug my requests.

Solution: Using the ObservabilityPolicy, an app dev can now enable and configure tracing for their Route(s). The policy will only be applied if the NginxProxy configuration containing the tracing collector endpoint has been defined and attached to the GatewayClass. The policy can be attached to one or more HTTP or GRPC Routes.

Updated span attributes from the NginxProxy to be applied at the location block context, otherwise they are overwritten.

Also added functional tests to ensure that the complete solution is working.
    @sjberman
    sjberman committed May 29, 2024
    Configuration menu
    Copy the full SHA
    3f85eff View commit details
    Browse the repository at this point in the history

  2. Add functional tests for tracing 

    Verify end to end tracing by creating a collector and sending trace data to it.

Test cases:
1. one policy attached to one route
2. one policy attached to multiple routes
    @sjberman
    sjberman committed May 29, 2024
    Configuration menu
    Copy the full SHA
    0a1369e View commit details
    Browse the repository at this point in the history

  3. Tracing test is flaky; add retry

    @sjberman
    sjberman committed May 29, 2024
    Configuration menu
    Copy the full SHA
    2a32f54 View commit details
    Browse the repository at this point in the history

  4. Update validation struct name and add condition

    @sjberman
    sjberman committed May 29, 2024
    Configuration menu
    Copy the full SHA
    55f0d7f View commit details
    Browse the repository at this point in the history

  5. Product code review

    @sjberman
    sjberman committed May 29, 2024
    Configuration menu
    Copy the full SHA
    ab5d3e3 View commit details
    Browse the repository at this point in the history

  6. Test code review

    @sjberman
    sjberman committed May 29, 2024
    Configuration menu
    Copy the full SHA
    e600533 View commit details
    Browse the repository at this point in the history

  7. Update ratio name

    @sjberman
    sjberman committed May 29, 2024
    Configuration menu
    Copy the full SHA
    6338e22 View commit details
    Browse the repository at this point in the history

  8. Address recent comments

    @sjberman
    sjberman committed May 29, 2024
    Configuration menu
    Copy the full SHA
    54b919e View commit details
    Browse the repository at this point in the history

  9. Fix test

    @sjberman
    sjberman committed May 29, 2024
    Configuration menu
    Copy the full SHA
    2655060 View commit details
    Browse the repository at this point in the history

  10. Add unit tests; comments

    @sjberman
    sjberman committed May 29, 2024
    Configuration menu
    Copy the full SHA
    807b758 View commit details
    Browse the repository at this point in the history

  11. Valid nginxproxy for http2

    @sjberman
    sjberman committed May 29, 2024
    Configuration menu
    Copy the full SHA
    ac840c4 View commit details
    Browse the repository at this point in the history