Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add possibility to provide custom pod annotations #2250

Merged
merged 4 commits into from
Jul 17, 2024
Merged

Add possibility to provide custom pod annotations #2250

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c24cf2c
Add possibility to provide custom pod annotations
Jul 16, 2024
0c7977b
Trim trailing white space
Jul 16, 2024
867aa2c
Add additional if statement before the annotations and remove trim
Jul 17, 2024
46fd4eb
Merge branch 'main' into feature/allow-custom-pod-annotations
Jul 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions charts/nginx-gateway-fabric/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -285,6 +285,7 @@ The following table lists the configurable parameters of the NGINX Gateway Fabri
| `nginxGateway.leaderElection.enable` | Enable leader election. Leader election is used to avoid multiple replicas of the NGINX Gateway Fabric reporting the status of the Gateway API resources. If not enabled, all replicas of NGINX Gateway Fabric will update the statuses of the Gateway API resources. | bool | `true` |
| `nginxGateway.leaderElection.lockName` | The name of the leader election lock. A Lease object with this name will be created in the same Namespace as the controller. | string | Autogenerated if not set or set to "". |
| `nginxGateway.lifecycle` | The lifecycle of the nginx-gateway container. | object | `{}` |
| `nginxGateway.podAnnotations` | Set of custom annotations for the NGINX Gateway Fabric pods. | object | `{}` |
| `nginxGateway.productTelemetry.enable` | Enable the collection of product telemetry. | bool | `true` |
| `nginxGateway.readinessProbe.enable` | Enable the /readyz endpoint on the control plane. | bool | `true` |
| `nginxGateway.readinessProbe.initialDelaySeconds` | The number of seconds after the Pod has started before the readiness probes are initiated. | int | `3` |
Expand Down
7 changes: 5 additions & 2 deletions charts/nginx-gateway-fabric/templates/deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,14 +15,17 @@ spec:
metadata:
labels:
{{- include "nginx-gateway.selectorLabels" . | nindent 8 }}
{{- if .Values.metrics.enable }}
lucacome marked this conversation as resolved.
Show resolved Hide resolved
annotations:
{{- if .Values.nginxGateway.podAnnotations }}
{{- toYaml .Values.nginxGateway.podAnnotations | trim | nindent 8 }}
lucacome marked this conversation as resolved.
Show resolved Hide resolved
{{- end }}
{{- if .Values.metrics.enable }}
prometheus.io/scrape: "true"
prometheus.io/port: "{{ .Values.metrics.port }}"
{{- if .Values.metrics.secure }}
prometheus.io/scheme: "https"
{{- end }}
{{- end }}
{{- end }}
spec:
containers:
- args:
Expand Down
3 changes: 3 additions & 0 deletions charts/nginx-gateway-fabric/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,9 @@ nginxGateway:
# belong to its class - i.e. have the "gatewayClassName" field resource equal to the class.
gatewayClassName: nginx

# -- Set of custom annotations for the NGINX Gateway Fabric pods.
podAnnotations: {}

# -- Set of custom annotations for GatewayClass objects.
gatewayClassAnnotations: {}

Expand Down
Loading