Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Programmed status for listener #786

Merged
merged 1 commit into from
Jun 23, 2023

Conversation

sjberman
Copy link
Contributor

Problem: programmed status was set for gateway but not for listeners

Solution: programmed status now set for listeners. Is set to false when the listener is invalid or nginx fails to reload.

Testing: Verified that a listener contains the programmed status, whether valid or invalid.

Closes #712

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

Problem: programmed status was set for gateway but not for listeners

Solution: programmed status now set for listeners. Is set to false when the listener is invalid or nginx fails to reload.
@sjberman sjberman requested a review from a team as a code owner June 23, 2023 16:41
@github-actions github-actions bot added documentation Improvements or additions to documentation enhancement New feature or request labels Jun 23, 2023
@sjberman sjberman merged commit 08e54e0 into nginxinc:main Jun 23, 2023
@sjberman sjberman deleted the feature/listener-status branch June 23, 2023 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Set Programmed Condition in Listener Status
3 participants