Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: create test and release pipelines #28

Merged
merged 7 commits into from
Oct 16, 2024
Merged

feat: create test and release pipelines #28

merged 7 commits into from
Oct 16, 2024

Conversation

Spikatrix
Copy link
Collaborator

No description provided.

@Spikatrix Spikatrix self-assigned this Oct 7, 2024
@Spikatrix Spikatrix marked this pull request as draft October 7, 2024 16:44
@Spikatrix Spikatrix marked this pull request as ready for review October 9, 2024 07:32
Copy link
Contributor

@irfan798 irfan798 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets use main branch as development branch

And release branch as release

@@ -19,7 +19,6 @@
"build": "yarn clean && yarn compile",
"compile": "tsc -p tsconfig.json -outDir ./dist",
"test": "jest",
"prepublish": "yarn build",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why remove build?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The prepublish script gets run whenever yarn/yarn install/yarn add is executed which was annoying. IMO, running install shouldn't trigger a build.
Upstream issue: yarnpkg/yarn#3209

.github/workflows/release.yml Show resolved Hide resolved
.github/workflows/sync-main-branch.yml Outdated Show resolved Hide resolved
@irfan798 irfan798 merged commit f884f7b into main Oct 16, 2024
1 check passed
Copy link

🎉 This PR is included in version 1.2.0-beta.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants