build: Implement build process that complies with the Angular Package Format #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MikeRyanDev
force-pushed
the
build/ng-package-format
branch
3 times, most recently
from
5e92ebf
to
9083c0a
Compare
brandonroberts
requested changes
Apr 18, 2017
| moduleName: 'ngrx.routerStore', | ||
| globals: { | ||
| '@ngrx/store': 'ngrx.store', | ||
| '@ngrx/store': 'ngrx.store', |
There was a problem hiding this comment.
Is this second one supposed to be @ngrx/store/index': 'ngrx.store'?
| moduleName: 'ngrx.storeDevtools', | ||
| globals: { | ||
| '@angular/core': 'ng.core', | ||
| '@ngrx/store': 'ngrx.store', | ||
| '@ngrx/store': 'ngrx.store', |
MikeRyanDev
force-pushed
the
build/ng-package-format
branch
from
9083c0a
to
163aef0
Compare
brandonroberts
approved these changes
Apr 18, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New build script implements v4.0 of the Angular Package Format: https://docs.google.com/document/d/1CZC2rcpxffTDfRDs6p1cfbmKNLA6x5O-NtkJglDaBVs/edit#heading=h.k0mh3o8u5hx
Build tools are basically a TypeScript re-implementation of Angular's
build.sh, found here: https://github.com/angular/angular/blob/master/build.shFor better or worse this causes the test and build scripts to go outside of Lerna. This PR currently leaves behind the NGC integration tests for @ngrx/store and the full e2e tests for @ngrx/router-store. I will re-add them in a followup PR.
This should make the packages releasable if we want to tag an early alpha ¯\__(ツ)_/¯