Omit percentage when zero percent

nguyenphihung6992 · Jul 31, 2018 · c7ad326 · c7ad326
1 parent 36dce43
commit c7ad326
Show file tree

Hide file tree

Showing 2 changed files with 36 additions and 1 deletion.
diff --git a/OpenPrFunction/PullRequestBody.cs b/OpenPrFunction/PullRequestBody.cs
@@ -56,7 +56,16 @@ public static string Generate(string commitBody)
                 var sb = new StringBuilder();
                 sb.AppendLine("## Beep boop. Your images are optimized!");
                 sb.AppendLine();
-                sb.AppendLine($"Your image file size has been reduced by **{imageStats[0].Percent:N0}%** 🎉");
+
+                if (imageStats[0].Percent == 0)
+                {
+                    sb.AppendLine("Your image file size has been reduced!");
+                }
+                else
+                {
+                    sb.AppendLine($"Your image file size has been reduced by **{imageStats[0].Percent:N0}%** 🎉");
+                }
+
                 sb.AppendLine();
                 sb.AppendLine("<details>");
 

diff --git a/Test/PullRequestBodyTests.cs b/Test/PullRequestBodyTests.cs
@@ -51,6 +51,32 @@ public void GivenMultiImageCommitMessage_ShouldFormatMarkdownTable()
             Assert.AreEqual(expectedMarkdown, result);
         }
 
+        [TestMethod]
+        public void GivenZeroPercentReductionCommitMessage_ShouldOmitPercentage()
+        {
+            var commitMessage = "[ImgBot] optimizes images" + Environment.NewLine +
+                         Environment.NewLine +
+                         "/featured-marketplace.png -- 163.11kb -> 160.11kb (0.02%)" + Environment.NewLine;
+
+            var expectedMarkdown = "## Beep boop. Your images are optimized!" + Environment.NewLine +
+                          Environment.NewLine +
+                          "Your image file size has been reduced!" + Environment.NewLine +
+                          Environment.NewLine +
+                          "<details>" + Environment.NewLine +
+                          "<summary>" + Environment.NewLine +
+                          "Details" + Environment.NewLine +
+                          "</summary>" + Environment.NewLine +
+                          Environment.NewLine +
+                          "| File | Before | After | Percent reduction |" + Environment.NewLine +
+                          "|:--|:--|:--|:--|" + Environment.NewLine +
+                          "| /featured-marketplace.png | 163.11kb | 133.44kb | 18.19% |" + Environment.NewLine +
+                          "</details>" + expectedFooter;
+
+            var result = PullRequestBody.Generate(commitMessage);
+
+            Assert.AreEqual(expectedMarkdown, result);
+        }
+
         [TestMethod]
         public void GivenSingleImageCommitMessage_ShouldFormatMarkdownTable()
         {