-
Notifications
You must be signed in to change notification settings - Fork 926
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
5.1.0 release #1525
5.1.0 release #1525
Conversation
cadf8cf
to
b7ff693
Compare
b7ff693
to
82e4468
Compare
ed55537
to
4340576
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have already updated the release notes and prepared the GitHub release draft.
* In GitHub, make sure no open issues have milestone set to the release | ||
that is about to happen (as these will show in the release notes). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
as these will show in the release notes
No more true with GitReleaseManager. It only takers into account closed PR/issues.
|
||
* Create a draft release in Github with GitReleaseManager. If you have used | ||
the NHibernate build menu, it should be available in Tools\gitreleasemanage.x.x.x\ | ||
(change x.x.x by its current version in tools). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Its chocolatey version is obsolete and unable to work with current GitHub.
4340576
to
12fe97d
Compare
releasenotes.txt
Outdated
* #1403 Add timeouts support to MultiCriteria | ||
* #1377 Logging refactoring | ||
* #954 NH-3807 - Support for .NET Core 2.0 | ||
* #948 NH-3435 - Ability to select the root entity in a criteria projection |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this issue needs to be renamed to "Ability to select entities in a criteria projection" . As implementation #1471 is not limited to root entity.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
12fe97d
to
c0b9b8a
Compare
|
||
** Highlights | ||
* NHibernate has gained two new target frameworks: .Net Core 2.0 and .Net Standard 2.0. NHibernate NuGet package | ||
provides them, along with the .Net framework 4.6.1 build. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to mention limitations:
- Binary serialization is not supported - the user shall implement serialization surrogates for
System.Type
,FieldInfo
,PropertyInfo
,MethodInfo
,ConstructorInfo
,Delegate
, etc. - other limitations mentioned in the PR.
ReleaseProcedure.txt
Outdated
If no error or other issue requiring further changes occurred, merge | ||
the release PR and wait for the resulting commit CI release build. | ||
|
||
* Retrieves the artifacts of the CI release build. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Retrieve
10b5b5c
to
922f76f
Compare
00c72eb
to
b44c03a
Compare
Its chocolatey version is obsolete and unable to access current GitHub. Only its NuGet version is currently usable. (Its MyGet feed seems gone.)
b44c03a
to
8fe355c
Compare
So well, what about #626 "Split database providers into own projects"? I have reviewed it one more time and approved it This aside, what should be the "immediate" plan:
|
|
Regressions and bugs ideally would be on a 5.1.x branch so 5.2 changes can immediately be merged to trunk. |
In order to avoid forgetting breaking changes, here is a start of release notes.
Obsolete
attributes.)