fix: resolve schedule rendering issues on month view (#646)

[jungeun-cho]

Please check if the PR fulfills these requirements

• It's submitted to right branch according to our branching model
• It's right issue type on title
• When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)
• The commit message follows our guidelines
• Tests for the changes have been added (for bug fixes/features)
• Docs have been added/updated (for bug fixes/features)
• It does not introduce a breaking change or has description for the breaking change

Description

• fix: When the end time of the schedule is resized to the previous date in the monthly view, the schedule size rendered is restored ( When the end time of the schedule is resized to the previous date in the monthly view, the schedule size rendered is restored #646 issue1)

AS-IS	TO-BE

• fix : resolve midnight schedule on monthly view( When the end time of the schedule is resized to the previous date in the monthly view, the schedule size rendered is restored #646 issue2)

AS-IS	TO-BE

• fix: resolve allday schedule (start and end same midnight) issue on monthly view(fix change an all-day schedule to a new single day failed. #657)
  To reproduce

1. on monthly view,
2. When adding a new schedule with the default schedule creation popup
3. enter start time 2020-07-23 00:00, end time 2020-07-23 00:00 and 'All day' checked
   

AS-IS	TO-BE

---

Thank you for your contribution to TOAST UI product. 🎉 😘 ✨

[jungeun-cho]

@lja1018

[dongsik-yoo]

[07/01] Reviewed.
In case of issue No.1, dragging that event must be tested with same manner(resizing it). When dragging that event, what if start and end hours are changed? It might be another bug.

[lja1018]

[07/01] Reviewed.

[jungeun-cho]

ok to test

[lja1018]

[07/27] Reviewed.

[lja1018]

How about doing this

return {
  start: new TZDate(isAllDay ? datetime.start(startDate) : startDate),
  end: new TZDate(isAllDay ? datetime.renderEnd(startDate, endDate) : endDate)
};

[dilyanpalauzov]

I have two theoretical questions, for which I have not done tests:

• if an event ends at midnight, e.g. 2020-10-05T00-00-00, does the above code, and all other code, hide the event from 5th October?

• a schedule can be isAllday, or its category can be 'time'. If the duration is more than 24h, controller/base.js groupFunc handles the schedule as being allday, sometimes. When is an event, lasting at least 24h, handled as allday and when not, if its isAllday property is not set?

[stale]

This issue has been automatically marked as inactive because there hasn’t been much going on it lately. It is going to be closed after 7 days. Thanks!

[stale]

This issue will be closed due to inactivity. Thanks for your contribution!

[swtalk]

Dooray! 메일 발송 실패 안내 메일 발송 실패 안내 박시우(viewrain@nhn.com) 님께 보낸 메일이 전송되지 못하였습니다. 실패 사유를 확인해보세요. * 받는 사람 :  박시우(viewrain@nhn.com) * 발송 시간 :  2020-09-03T09:16:08 * 메일 제목 :  Re: [nhn/tui.calendar] fix: resolve schedule rendering issues on month view (#646) (#647) * 실패 사유 :  받는 사람이 회원님의 메일을 수신차단 하였습니다. 이 메일은 발신전용으로 회신되지 않습니다. 더 궁금하신 사항은 dooray@nhn.com 으로 문의해 주시기 바랍니다. © Dooray!.