fix: always consider timezone when set allday schedule period(fix #662) #667
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lhysdl
changed the title
|
Can one of the admins verify this patch? |
|
ok to test |
jungeun-cho
reviewed
Jul 23, 2020
src/js/model/schedule.js
Outdated
Comment on lines
273
to
275
| if (util.isString(start)) { | ||
| start = datetime.parse(start.substring(0, 10)); | ||
| } else { | ||
| start = new TZDate(start || Date.now()); | ||
| } | ||
| if (util.isString(end)) { | ||
| end = datetime.parse(end.substring(0, 10)); | ||
| } else { | ||
| end = new TZDate(end || this.start); | ||
| } | ||
|
|
||
| this.start = start; | ||
| this.start = new TZDate(start || Date.now()); | ||
| this.start.setHours(0, 0, 0); | ||
| this.end = end || new TZDate(this.start); | ||
| this.end = new TZDate(end || this.start); | ||
| this.end.setHours(23, 59, 59); |
There was a problem hiding this comment.
You can use start, end of datetime
https://github.com/nhn/tui.calendar/blob/master/src/js/common/datetime.js#L396
https://github.com/nhn/tui.calendar/blob/master/src/js/common/datetime.js#L408
this.start = datetime.start(new TZDate(start || Date.now()));
this.end = datetime.end(new TZDate(end || this.start));
|
@dongsik-yoo check this PR. |
|
This issue has been automatically marked as inactive because there hasn’t been much going on it lately. It is going to be closed after 7 days. Thanks! |
jungeun-cho
approved these changes
Aug 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
fix #xxx[,#xxx], where "xxx" is the issue number)Description
Thank you for your contribution to TOAST UI product. 🎉 😘 ✨