Feat : custom timezone spec (#723) #721
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jungeun-cho
changed the title
|
ok to test |
dongsik-yoo
reviewed
Nov 25, 2020
src/js/common/timezone.js
Outdated
|
|
||
| /** | ||
| * Set primary timezone code | ||
| * @param {string} timezoneCode - timezone code (such as 'Asia/Seoul', 'America/New_York') |
There was a problem hiding this comment.
"IANA time zone names" 이라고 명시해 주면 좋을 것 같아요.
There was a problem hiding this comment.
timezone name (time zone names of the IANA time zone database, such as 'Asia/Seoul', 'America/New_York')
이렇게 설명하는건어떻할까요?
src/js/common/timezone.js
Outdated
| * @param {Timezone} timezoneObj - {@link Timezone} | ||
| */ | ||
| function setPrimaryTimezoneByOption(timezoneObj) { | ||
| var timezoneCode = timezoneObj.timezone; |
There was a problem hiding this comment.
timezone, timeZone의 네이밍이 통일되어 있지 않습니다. 적어도 인터페이스에서는 맞추어야 되겠습니다.
There was a problem hiding this comment.
인터페이스 확인 부탁드립니다.
timezone: {
zones: [
{
timezoneName: 'Asia/Seoul',
displayLabel: 'GMT+09:00',
tooltip: 'Seoul'
},
{
timezoneName: 'America/New_York',
displayLabel: 'GMT-05:00',
tooltip: 'New York',
}
],
offsetCalculator: function(timezone, timestamp){
// e.g. +09:00 => -540, -04:00 => 240
return moment.tz.zone(timezone).utcOffset(timestamp);
},
}
dongsik-yoo
reviewed
Dec 10, 2020
| @@ -49,7 +46,7 @@ var differentOffset = { | |||
| * @private | |||
| */ | |||
| function getTimezoneOffset(timestamp) { | |||
| timestamp = timestamp || Date.now(); | |||
| timestamp = !util.isUndefined(timestamp) ? timestamp : Date.now(); | |||
|
기존의 |
네, 하위버전 호환가능하도록 기존에 사용된 |
dongsik-yoo
reviewed
Dec 23, 2020
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
fix #xxx[,#xxx], where "xxx" is the issue number)Description
If the system local setting uses a time zone that includes DST, the schedule should always be rendered the same, regardless of whether the time is summer or standard time at the time the calendar instance is created.
The custom timezone spec has been changed. (feat Custom time zone designation option specification definition #723 )
Thank you for your contribution to TOAST UI product. 🎉 😘 ✨