Added check for metadata validation #807
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like this branch contains the changes from your encoder / decoder branch. When you created the branch did you branch off of main or off of the encoder branch? |
LazeringDeath
force-pushed
the
users/tynguyen/metadata_validation
branch
from
498923f
to
201e820
Compare
dixonjoel
reviewed
Jul 22, 2024
dixonjoel
approved these changes
Jul 22, 2024
dixonjoel
requested review from
csjall,
bkeryan,
mshafer-NI and
nstokes-nati
as code owners
bkeryan
requested changes
Jul 22, 2024
packages/service/ni_measurement_plugin_sdk_service/measurement/service.py
Outdated
Show resolved
Hide resolved
packages/service/ni_measurement_plugin_sdk_service/measurement/service.py
Show resolved
Hide resolved
bkeryan
requested changes
Jul 26, 2024
packages/service/ni_measurement_plugin_sdk_service/measurement/service.py
Outdated
Show resolved
Hide resolved
LazeringDeath
force-pushed
the
users/tynguyen/metadata_validation
branch
from
0528c15
to
439c285
Compare
bkeryan
requested changes
Jul 30, 2024
packages/service/ni_measurement_plugin_sdk_service/_internal/parameter/metadata.py
Outdated
Show resolved
Hide resolved
packages/service/ni_measurement_plugin_sdk_service/_internal/parameter/metadata.py
Outdated
Show resolved
Hide resolved
This was referenced Aug 1, 2024
bkeryan
approved these changes
Aug 1, 2024
packages/service/ni_measurement_plugin_sdk_service/_internal/parameter/metadata.py
Outdated
Show resolved
Hide resolved
packages/service/ni_measurement_plugin_sdk_service/_internal/parameter/metadata.py
Outdated
Show resolved
Hide resolved
packages/service/ni_measurement_plugin_sdk_service/_internal/parameter/metadata.py
Show resolved
Hide resolved
bkeryan
approved these changes
Aug 5, 2024
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this Pull Request accomplish?
Check metadata for any invalid characters.
Why should this Pull Request be merged?
Resolve issue#25
What testing has been done?
Created a test to ensure the check is working.