Update measurement service to get version from .serviceconfig

[nick-beer]

• This contribution adheres to CONTRIBUTING.md.

What does this Pull Request accomplish?

Add support for reading a measurement's version from its .serviceconfig file, as well as passing that version through discovery service's RegisterService API.

To do this:

• Make version and ui_file_paths parameters to the MeasurementService constructor optional
• If version is specified in the constructor, use it unless it is also specified in the .serviceconfig file AND the two values are different. If the values are different, raise an error
• Add a version property to ServiceInfo
• Pass ServiceInfo.version through the RegisterServiceRequest inside the DiscoveryClient.

Why should this Pull Request be merged?

We're working to add version support to our plugins. The intention is for the version of a plugin to be stored in its .serviceconfig file and passed to discovery service when it registers itself.

What testing has been done?

A couple new tests have been written, and a couple existing tests have been updated to account for the presence of a version in the service config.

[github-actions]

Test Results

    30 files  ±  0      30 suites  ±0   42m 57s ⏱️ - 6m 6s
   643 tests + 11     643 ✅ + 15      0 💤 ±0  0 ❌  - 4 
15 910 runs  +330  14 840 ✅ +334  1 070 💤 ±0  0 ❌  - 4 

Results for commit 3bb7a41. ± Comparison against base commit 7d1a5fe.

This pull request removes 7 and adds 18 tests. Note that renamed tests count towards both.

tests.unit.test_service ‑ test___service_config___create_measurement_service___service_info_matches_service_config[example.AllAnnotations.serviceconfig-provided_interfaces5-provided_annotations5]
tests.unit.test_service ‑ test___service_config___create_measurement_service___service_info_matches_service_config[example.CustomAnnotations.serviceconfig-provided_interfaces6-provided_annotations6]
tests.unit.test_service ‑ test___service_config___create_measurement_service___service_info_matches_service_config[example.OnlyCollection.serviceconfig-provided_interfaces3-provided_annotations3]
tests.unit.test_service ‑ test___service_config___create_measurement_service___service_info_matches_service_config[example.OnlyTags.serviceconfig-provided_interfaces4-provided_annotations4]
tests.unit.test_service ‑ test___service_config___create_measurement_service___service_info_matches_service_config[example.serviceconfig-provided_interfaces0-provided_annotations0]
tests.unit.test_service ‑ test___service_config___create_measurement_service___service_info_matches_service_config[example.v1.serviceconfig-provided_interfaces1-provided_annotations1]
tests.unit.test_service ‑ test___service_config___create_measurement_service___service_info_matches_service_config[example.v2.serviceconfig-provided_interfaces2-provided_annotations2]

tests.unit.test_metadata ‑ test___display_name_invalid_characters___validate___raises_value_exception[ test_string]
tests.unit.test_metadata ‑ test___display_name_invalid_characters___validate___raises_value_exception[]
tests.unit.test_metadata ‑ test___display_name_invalid_characters___validate___raises_value_exception[_____()!]
tests.unit.test_metadata ‑ test___display_name_invalid_characters___validate___raises_value_exception[test@string]
tests.unit.test_metadata ‑ test___display_name_valid_characters___validate___raises_no_exception[Test String: -10]
tests.unit.test_metadata ‑ test___display_name_valid_characters___validate___raises_no_exception[tEsT StRIng?]
tests.unit.test_metadata ‑ test___display_name_valid_characters___validate___raises_no_exception[test_string!]
tests.unit.test_metadata ‑ test___display_name_valid_characters___validate___raises_no_exception[teststring()]
tests.unit.test_service ‑ test___service_config___create_measurement_service___service_info_matches_service_config[example.AllAnnotations.serviceconfig-1.0.6-provided_interfaces5-provided_annotations5]
tests.unit.test_service ‑ test___service_config___create_measurement_service___service_info_matches_service_config[example.CustomAnnotations.serviceconfig-1.0.7-provided_interfaces6-provided_annotations6]
…

♻️ This comment has been updated with latest results.

[jayaseelan-james]

@nick-beer
[Question] I'm just curious to know that with this change, will we update the template in our measurement-plugin-generator to have a version field in the .serviceconfig going forward?

[nick-beer]

@nick-beer [Question] I'm just curious to know that with this change, will we update the template in our measurement-plugin-generator to have a version field in the .serviceconfig going forward?

@jayaseelan-james - Good catch! Yes, this PR has been updated to include the necessary changes to the generator.

[dixonjoel]

I'd like to see the changes with multiple versions.

[nick-beer]

I'd like to see the changes with multiple versions.

@dixonjoel - can you explain what you mean by this? I don't follow.

[dixonjoel]

@nick-beer "Sorry - I reset you without seeing this message. Thanks for pointing this out - I think it makes sense for ServiceInfo to have versions rather than version. I'll make the update." Maybe I misunderstood this. You resolved this conversation. What changed?

[dixonjoel]

@nick-beer Oh, this update? Sorry I missed this.
f438446

[nick-beer]

@nick-beer Oh, this update? Sorry I missed this. f438446

@dixonjoel - yeah, that's the one that updated ServiceInfo to have the possibility of multiple versions.

[bkeryan]

Approved with suggestion