Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add stream_measure API in Measurement Plug-In Client #856

Merged
merged 47 commits into from
Sep 2, 2024
Merged

Add stream_measure API in Measurement Plug-In Client #856

merged 47 commits into from
Sep 2, 2024

Conversation

Jotheeswaran-Nandagopal
Copy link
Contributor

What does this Pull Request accomplish?

  • Added stream-measure API support to Measurement Plug-In Client.
  • Added Test cases for stream-measure API.

Why should this Pull Request be merged?

  • Stream-measure API supports user to interact with streaming measurement data services.

What testing has been done?

  • Tested manually.
  • Executed existing and new automated tests.

@Jotheeswaran-Nandagopal
update : change the plugin generator files to separate folder
81eba0f
@Jotheeswaran-Nandagopal
fix : resolve formatting
8fe0744
@Jotheeswaran-Nandagopal
feat : add changes to client template
7d48408
@Jotheeswaran-Nandagopal
feat : add template creation implementation
228b0f3
@Jotheeswaran-Nandagopal
feat : measurement plugin client generator
dfa65d3
@Jotheeswaran-Nandagopal
fix : resolve formatting and lint issues
32cbd19
@Jotheeswaran-Nandagopal
fix : add exception handling
b5c42b0
@Jotheeswaran-Nandagopal
update poetry lock
cbc24c6
@Jotheeswaran-Nandagopal
fix : resolve issues due to merge
1e2b815
@Jotheeswaran-Nandagopal
fix : pr build and restructure folder
44f2a66
@Jotheeswaran-Nandagopal
fix : resolve comments
9f8d977
@Jotheeswaran-Nandagopal
fix : resolve pr comments
9f2e78d
@Jotheeswaran-Nandagopal
fix : resolve pr comments
afa4a90
@Jotheeswaran-Nandagopal
update: poetry lock
c315183
@Jotheeswaran-Nandagopal
fix : resolve comments
77841a8
@Jotheeswaran-Nandagopal
fix : resolve comments
85fa5f4
@Jotheeswaran-Nandagopal
fix :resolve comment
becbf9a
@Jotheeswaran-Nandagopal
fix : resolve comments
07c9d2f
@Jotheeswaran-Nandagopal
fix : formatting error
078260c
@Jotheeswaran-Nandagopal
fix : update the argument in click
e7af661
@Jotheeswaran-Nandagopal
fix : formatting
7a664e9
@Jotheeswaran-Nandagopal
fix : update the logic to use sets
bb50abe
@Jotheeswaran-Nandagopal
fix : exception handling
b2cb612
@Jotheeswaran-Nandagopal
refactor: remove unused import
c1c9c9b
@Jotheeswaran-Nandagopal
fix : resolve comments
5e9a099
@Jotheeswaran-Nandagopal
fix : pipeline failure
648b1f8
@Jotheeswaran-Nandagopal
fix : resolve comments
13dc609
@Jotheeswaran-Nandagopal
refactor : formatting
7eb96e2
@Jotheeswaran-Nandagopal
fix : add regex to validate class name
87f1d09
@Jotheeswaran-Nandagopal
fix : update error messages
3dc1062
@Jotheeswaran-Nandagopal Jotheeswaran-Nandagopal changed the base branch from users/jothees/measurement-client-one-line-approach to main August 29, 2024 13:43
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 29, 2024 •
edited
Loading

Test Results

    30 files  ± 0      30 suites  ±0   42m 4s ⏱️ -59s
   651 tests + 3     651 ✅ + 3      0 💤 ±0  0 ❌ ±0 
16 130 runs  +70  15 060 ✅ +70  1 070 💤 ±0  0 ❌ ±0 

Results for commit 4423eb1. ± Comparison against base commit 84af8a7.

♻️ This comment has been updated with latest results.

@Jotheeswaran-Nandagopal Jotheeswaran-Nandagopal changed the title Users/jothees/stream measure api Add stream_measure API in Measurement Plug-In Client Aug 29, 2024
bkeryan
bkeryan requested changes Aug 29, 2024
View reviewed changes
...rator/ni_measurement_plugin_sdk_generator/client/templates/measurement_plugin_client.py.mako Outdated Show resolved Hide resolved
...rator/ni_measurement_plugin_sdk_generator/client/templates/measurement_plugin_client.py.mako Outdated Show resolved Hide resolved
...rator/ni_measurement_plugin_sdk_generator/client/templates/measurement_plugin_client.py.mako Show resolved Hide resolved
...rator/ni_measurement_plugin_sdk_generator/client/templates/measurement_plugin_client.py.mako Outdated Show resolved Hide resolved
...rator/ni_measurement_plugin_sdk_generator/client/templates/measurement_plugin_client.py.mako Outdated Show resolved Hide resolved
packages/generator/tests/acceptance/test_streaming_measurement_client.py Show resolved Hide resolved
packages/generator/tests/acceptance/test_non_streaming_measurement_client.py Outdated Show resolved Hide resolved
packages/generator/tests/acceptance/test_non_streaming_measurement_client.py Outdated Show resolved Hide resolved
packages/generator/tests/acceptance/test_non_streaming_measurement_client.py Outdated Show resolved Hide resolved
packages/generator/tests/acceptance/test_streaming_measurement_client.py Outdated Show resolved Hide resolved
bkeryan
bkeryan approved these changes Aug 30, 2024
View reviewed changes
Copy link
Collaborator

@bkeryan bkeryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with suggestions:

  • Remove develop = true and run poetry lock --no-update
  • Change if output_metadata conditional to occur at run time

...rator/ni_measurement_plugin_sdk_generator/client/templates/measurement_plugin_client.py.mako Outdated Show resolved Hide resolved
@Jotheeswaran-Nandagopal Jotheeswaran-Nandagopal merged commit d520904 into main Sep 2, 2024
17 checks passed
@Jotheeswaran-Nandagopal Jotheeswaran-Nandagopal deleted the users/jothees/stream-measure-api branch September 13, 2024 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bkeryan bkeryan bkeryan approved these changes

@csjall csjall Awaiting requested review from csjall csjall is a code owner

@dixonjoel dixonjoel Awaiting requested review from dixonjoel dixonjoel is a code owner

@mshafer-NI mshafer-NI Awaiting requested review from mshafer-NI mshafer-NI is a code owner

@nstokes-nati nstokes-nati Awaiting requested review from nstokes-nati nstokes-nati is a code owner

@Avinash2Suresh Avinash2Suresh Awaiting requested review from Avinash2Suresh

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Jotheeswaran-Nandagopal @bkeryan