Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add multiple client generation #874

Merged
merged 13 commits into from
Sep 10, 2024
Merged

Add multiple client generation #874

merged 13 commits into from
Sep 10, 2024

Conversation

Jotheeswaran-Nandagopal
Copy link
Contributor

What does this Pull Request accomplish?

  • Add an option to create clients for all active measurement services.
  • Allow users to create multiple clients using one-line approach.
  • Add automation test for creating client for all active measurement services.

Why should this Pull Request be merged?

  • This implementation allows users to create multiple clients in a single command.

What testing has been done?

  • Tested manually.
  • Executed existing and new automated tests.

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 5, 2024 •
edited
Loading

Test Results

    30 files  ±0      30 suites  ±0   37m 42s ⏱️ - 1m 37s
   651 tests ±0     651 ✅ ±0      0 💤 ±0  0 ❌ ±0 
16 130 runs  ±0  15 060 ✅ ±0  1 070 💤 ±0  0 ❌ ±0 

Results for commit 27f545e. ± Comparison against base commit 5974af6.

♻️ This comment has been updated with latest results.

@Avinash2Suresh
Copy link
Contributor

@jayaseelan-james pls consider reviewing this PR

jayaseelan-james
jayaseelan-james approved these changes Sep 6, 2024
View reviewed changes
packages/generator/ni_measurement_plugin_sdk_generator/client/__init__.py Outdated Show resolved Hide resolved
packages/generator/ni_measurement_plugin_sdk_generator/client/__init__.py Outdated Show resolved Hide resolved
packages/generator/ni_measurement_plugin_sdk_generator/client/__init__.py Outdated Show resolved Hide resolved
packages/generator/ni_measurement_plugin_sdk_generator/client/__init__.py Outdated Show resolved Hide resolved
packages/generator/ni_measurement_plugin_sdk_generator/client/__init__.py Outdated Show resolved Hide resolved
packages/generator/ni_measurement_plugin_sdk_generator/client/_support.py Outdated Show resolved Hide resolved
packages/generator/ni_measurement_plugin_sdk_generator/client/_support.py Outdated Show resolved Hide resolved
packages/generator/ni_measurement_plugin_sdk_generator/client/_support.py Outdated Show resolved Hide resolved
packages/generator/tests/acceptance/test_client_generator.py Outdated Show resolved Hide resolved
packages/generator/tests/acceptance/test_client_generator.py Outdated Show resolved Hide resolved
@Jotheeswaran-Nandagopal
Copy link
Contributor Author

Jotheeswaran-Nandagopal commented Sep 6, 2024 •
edited
Loading

@mshafer-NI We are waiting for your review before proceeding with this PR. Kindly, review this PR when you are available.

@Jotheeswaran-Nandagopal Jotheeswaran-Nandagopal merged commit c57f8b4 into main Sep 10, 2024
17 checks passed
@Jotheeswaran-Nandagopal Jotheeswaran-Nandagopal deleted the users/jothees/multiple-client branch September 13, 2024 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dixonjoel dixonjoel dixonjoel approved these changes

@jayaseelan-james jayaseelan-james jayaseelan-james approved these changes

@Avinash2Suresh Avinash2Suresh Avinash2Suresh approved these changes

@SowmyaRavee SowmyaRavee Awaiting requested review from SowmyaRavee

@csjall csjall Awaiting requested review from csjall csjall is a code owner

@bkeryan bkeryan Awaiting requested review from bkeryan bkeryan is a code owner

@nstokes-nati nstokes-nati Awaiting requested review from nstokes-nati nstokes-nati is a code owner

@mshafer-NI mshafer-NI Awaiting requested review from mshafer-NI mshafer-NI is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Jotheeswaran-Nandagopal @Avinash2Suresh @mshafer-NI @dixonjoel @jayaseelan-james