Update measurement client generator to interact with C# measurement services #889
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jotheeswaran-Nandagopal
requested review from
csjall,
dixonjoel,
bkeryan,
mshafer-NI and
nstokes-nati
as code owners
bkeryan
requested changes
Sep 16, 2024
...st_assets/example_renders/measurement_plugin_client/non_streaming_data_measurement_client.py
Show resolved
Hide resolved
...rator/ni_measurement_plugin_sdk_generator/client/templates/measurement_plugin_client.py.mako
Outdated
Show resolved
Hide resolved
bkeryan
requested changes
Sep 16, 2024
...rator/ni_measurement_plugin_sdk_generator/client/templates/measurement_plugin_client.py.mako
Outdated
Show resolved
Hide resolved
dixonjoel
approved these changes
Sep 17, 2024
|
@bkeryan, I have updated the changes. Kindly, help me reviewing the changes. |
1 task
bkeryan
approved these changes
Sep 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this Pull Request accomplish?
type_urltoMeasureRequest.configuration_parameters, while creating measure request, as the C# measurement services validatestype_url.Why should this Pull Request be merged?
type_url, the generated measurement client throws error while calling measure API (Bug #851).What testing has been done?