Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add acceptance test to interactive mode of client generation #892

Merged
merged 46 commits into from
Sep 19, 2024
Merged

Add acceptance test to interactive mode of client generation #892

merged 46 commits into from
Sep 19, 2024

Conversation

Jotheeswaran-Nandagopal
Copy link
Contributor

@Jotheeswaran-Nandagopal Jotheeswaran-Nandagopal commented Sep 17, 2024 •
edited
Loading

What does this Pull Request accomplish?

  • Added a couple of test cases for interactive mode of client generation in test_client_generator.py.
  • Updated the click module tests with CliRunner.

Why should this Pull Request be merged?

  • This implementation contains the automation testing for the interactive mode of Measurement Plug-In Client generation workflow.
  • Removed the systemExit catching logics from the tests for modules using click under generator and replaced with CLIRunner.

What testing has been done?

  • Existing automated tests passed.
  • Newly added acceptance tests passed.

@MounikaBattu17
Feat: Add interactive mode for client generation
0f51d40
@MounikaBattu17
Fix: Lint errors
333ef33
@MounikaBattu17
Fix: Minor .message improvements
e96824a
@MounikaBattu17
Refractor: craeting class and module names methods
e15a116
@MounikaBattu17
Client: Use click group as script command
13fe908
@MounikaBattu17
Fix: Add interactive mode in existing command
9173aee
@MounikaBattu17
Fix: Remove command name
0ed470d
@MounikaBattu17
Client: List display name instead of service class
915181e
@MounikaBattu17
Client: Generate default class and module name for interactive mode
c27f72e
@MounikaBattu17
Client: Refractor display messages
a5fd969
@MounikaBattu17
Client: Capiltialize the noun python
bf15afa
@MounikaBattu17
Client: Spacing in options help context
8c0840b
@MounikaBattu17
Client: Fix method signatures
0a96c97
@MounikaBattu17
Client; Fix lint errors
9522d8c
@MounikaBattu17
Client: Update directory_out default value to None
63140d4
@MounikaBattu17
Client: Update exit message
3fe0238
@MounikaBattu17
Client: Update parameter names
72d16c4
@MounikaBattu17
Client: Use optgroup to group different modes
b5ea612
@MounikaBattu17
Client: Refractor create client method
84b3108
@MounikaBattu17
Client: Update directory out creation
ec125a8
@MounikaBattu17
Client: Update directory out in all mode
2b3dc51
@MounikaBattu17
Client: Update interactive exit message
bff6625
@MounikaBattu17
Client: Create class & module name for multiple clients
b93899b
@MounikaBattu17
Client: Remove exception for no service class
0448027
@MounikaBattu17
Packages: Add click-option-group
707386b
@MounikaBattu17
Client: Update context help
94084b5
@MounikaBattu17
Client: extract create_client into helper functions
16a4aa6
@MounikaBattu17
Client: Fix myPy errors
1a7fc57
@MounikaBattu17
Packages: Update click-option-group version
88a2280
@MounikaBattu17
Client: Update exit prompt message
19bc97d
@Jotheeswaran-Nandagopal Jotheeswaran-Nandagopal changed the base branch from users/mounika/client-interactive-mode to main September 17, 2024 15:11
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 17, 2024 •
edited
Loading

Test Results

    40 files  ± 0      40 suites  ±0   49m 55s ⏱️ - 1m 8s
   688 tests + 2     688 ✅ + 2      0 💤 ±0  0 ❌ ±0 
16 780 runs  +20  15 710 ✅ +20  1 070 💤 ±0  0 ❌ ±0 

Results for commit 44dd58b. ± Comparison against base commit a0a64d2.

This pull request removes 1 and adds 3 tests. Note that renamed tests count towards both. 
tests.acceptance.test_plugin_generator ‑ test___command_line_args___create_measurement_with_annotations___render_without_exception

tests.acceptance.test_client_generator ‑ test___command_line_args_with_registered_measurements___create_client_using_interactive_mode___renders_without_error
tests.acceptance.test_client_generator ‑ test___command_line_args_without_registering_any_measurement___create_client_using_interactive_mode___raises_exception
tests.acceptance.test_plugin_generator ‑ test___command_line_args___create_measurement_with_annotations___render_without_error

♻️ This comment has been updated with latest results.

@bkeryan bkeryan mentioned this pull request Sep 17, 2024
Merged
1 task
@Jotheeswaran-Nandagopal Jotheeswaran-Nandagopal merged commit 0a09759 into main Sep 19, 2024
17 checks passed
@Jotheeswaran-Nandagopal Jotheeswaran-Nandagopal deleted the users/jothees/tests-for-interactive-mode branch September 19, 2024 03:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bkeryan bkeryan bkeryan approved these changes

@csjall csjall Awaiting requested review from csjall csjall is a code owner

@dixonjoel dixonjoel Awaiting requested review from dixonjoel dixonjoel is a code owner

@nstokes-nati nstokes-nati Awaiting requested review from nstokes-nati nstokes-nati is a code owner

@mshafer-NI mshafer-NI Awaiting requested review from mshafer-NI mshafer-NI is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Jotheeswaran-Nandagopal @bkeryan @mshafer-NI @MounikaBattu17