Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

examples: Update service class of Game of Life example's .instudioproj and .sfp #919

Merged
merged 1 commit into from
Sep 24, 2024
Merged

examples: Update service class of Game of Life example's .instudioproj and .sfp #919

merged 1 commit into from
Sep 24, 2024

Conversation

bkeryan
Copy link
Collaborator

@bkeryan bkeryan commented Sep 23, 2024

What does this Pull Request accomplish?

Update service class of Game of Life example's .instudioproj and .sfp

Why should this Pull Request be merged?

Make example work out of the box.

What testing has been done?

Ran example.

@bkeryan bkeryan mentioned this pull request Sep 23, 2024
Merged
1 task
dixonjoel
dixonjoel approved these changes Sep 23, 2024
View reviewed changes
Copy link
Collaborator

@dixonjoel dixonjoel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching that Brad.

@github-actions GitHub Actions
Copy link

Test Results

    40 files  ±0      40 suites  ±0   48m 42s ⏱️ - 2m 53s
   692 tests ±0     692 ✅ ±0      0 💤 ±0  0 ❌ ±0 
16 820 runs  ±0  15 750 ✅ ±0  1 070 💤 ±0  0 ❌ ±0 

Results for commit f4055dc. ± Comparison against base commit 868b6db.

@dixonjoel dixonjoel merged commit 3a5b081 into main Sep 24, 2024
17 checks passed
@dixonjoel dixonjoel deleted the users/bkeryan/game-of-life-service-class-2 branch September 24, 2024 15:48
bkeryan added a commit that referenced this pull request Sep 24, 2024
@bkeryan
examples: Update service class of Game of Life example's `.instudiopr…
5b8d6f5 
…oj` and `.sfp` (#919)

examples: Resave GameOfLife.instudioproj/sfp with new service class
(cherry picked from commit 3a5b081)
@bkeryan bkeryan mentioned this pull request Sep 24, 2024
Merged
1 task
bkeryan added a commit that referenced this pull request Sep 24, 2024
@bkeryan
examples: Update service class of Game of Life example's `.instudiopr…
a7047bd 
…oj` and `.sfp` (#919)

examples: Resave GameOfLife.instudioproj/sfp with new service class
(cherry picked from commit 3a5b081)
bkeryan added a commit that referenced this pull request Sep 24, 2024
@bkeryan
[releases/2.1] Cherry-pick: examples: Update service class of Game of…
95afba8 
… Life example's .instudioproj and .sfp (#933)

examples: Update service class of Game of Life example's `.instudioproj` and `.sfp` (#919)

examples: Resave GameOfLife.instudioproj/sfp with new service class
(cherry picked from commit 3a5b081)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dixonjoel dixonjoel dixonjoel approved these changes

@csjall csjall Awaiting requested review from csjall csjall is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bkeryan @dixonjoel