Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[releases/2.1] Cherry-pick: [High Priority] Update default value for the pin map sites #921

Merged
merged 2 commits into from
Sep 24, 2024
Merged

[releases/2.1] Cherry-pick: [High Priority] Update default value for the pin map sites #921

merged 2 commits into from
Sep 24, 2024

Conversation

MounikaBattu17
Copy link
Contributor

What does this Pull Request accomplish?

Cherry-pick the change in PR #915.

@Jotheeswaran-Nandagopal @MounikaBattu17
[High Priority] Update default value for the pin map sites (#915)
1d44206 
fix: add default sites
(cherry picked from commit 868b6db)
@MounikaBattu17
Copy link
Contributor Author

MounikaBattu17 commented Sep 23, 2024 •
edited
Loading

@dixonjoel Can you please help approve this cherry-pick PR. Thanks.

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 23, 2024 •
edited
Loading

Test Results

    40 files  ±0      40 suites  ±0   47m 57s ⏱️ - 1m 18s
   692 tests ±0     692 ✅ ±0      0 💤 ±0  0 ❌ ±0 
16 820 runs  ±0  15 750 ✅ ±0  1 070 💤 ±0  0 ❌ ±0 

Results for commit 7d35241. ± Comparison against base commit c0d41be.

♻️ This comment has been updated with latest results.

@MounikaBattu17
Copy link
Contributor Author

MounikaBattu17 commented Sep 24, 2024 •
edited
Loading

@dixonjoel I hope we can merge this PR to the releases/2.1 branch since you have synced the last merged changes.

@dixonjoel dixonjoel merged commit dfab957 into releases/2.1 Sep 24, 2024
17 checks passed
@dixonjoel dixonjoel deleted the users/mounika/cherry-pick-fix-default-sites branch September 24, 2024 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dixonjoel dixonjoel dixonjoel approved these changes

@csjall csjall Awaiting requested review from csjall csjall is a code owner

@bkeryan bkeryan Awaiting requested review from bkeryan bkeryan is a code owner

@mshafer-NI mshafer-NI Awaiting requested review from mshafer-NI mshafer-NI is a code owner

@nstokes-nati nstokes-nati Awaiting requested review from nstokes-nati nstokes-nati is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MounikaBattu17 @dixonjoel @Jotheeswaran-Nandagopal