Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[releases/2.1] Cherry-pick: [High Priority] Client generator: provide support backward compatibility for Older libraries (#949) #951

Merged
merged 2 commits into from
Sep 27, 2024
Merged

[releases/2.1] Cherry-pick: [High Priority] Client generator: provide support backward compatibility for Older libraries (#949) #951

merged 2 commits into from
Sep 27, 2024

Conversation

Jotheeswaran-Nandagopal
Copy link
Contributor

What does this Pull Request accomplish?

Cherry-pick #949 into releases/2.1.

@Jotheeswaran-Nandagopal
[High Priority] Client generator: provide support backward compatibil…
07b53d2 
…ity for Older libraries (#949)

* fix: get version details from the resolve service with information api in the client generator

(cherry picked from commit 992c280)
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 27, 2024 •
edited
Loading

Test Results

    40 files      40 suites   53m 32s ⏱️
   698 tests    698 ✅     0 💤 0 ❌
16 980 runs  15 910 ✅ 1 070 💤 0 ❌

Results for commit 5b04005.

♻️ This comment has been updated with latest results.

@Jotheeswaran-Nandagopal
Copy link
Contributor Author

The pipeline is failing, as the release/2.1 branch doesn't have resolve_service_with_information. This PR is dependent on #950.

bkeryan
bkeryan approved these changes Sep 27, 2024
View reviewed changes
Copy link
Collaborator

@bkeryan bkeryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. Note that you will have to rebase against releases/2.1 or merge releases/2.1 into this branch when you retarget the PR.

@bkeryan bkeryan merged commit 7c19d3c into releases/2.1 Sep 27, 2024
17 checks passed
@bkeryan bkeryan deleted the users/jothees/cherry-pick-resolve-service-updation-in-generator branch September 27, 2024 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bkeryan bkeryan bkeryan approved these changes

@csjall csjall Awaiting requested review from csjall csjall is a code owner

@dixonjoel dixonjoel Awaiting requested review from dixonjoel dixonjoel is a code owner

@mshafer-NI mshafer-NI Awaiting requested review from mshafer-NI mshafer-NI is a code owner

@nstokes-nati nstokes-nati Awaiting requested review from nstokes-nati nstokes-nati is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Jotheeswaran-Nandagopal @bkeryan