[releases/2.1] Cherry-pick: [High Priority] Fix Path type conversion and type hints for client codegen #952
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…degen (#931) * generator: Fix Path type conversion for client outputs * generator: Annotate array configuration parameters as Iterable[T] and array output parameters as Sequence[T] * generator: Fix lint errors * service: Fix lint errors * service: Revert debugging code * service: Simplify convert_paths_to_strings and convert_strings_to_paths * generator: Simplify client imports `from typing import big, list, of, things` results in a lot of conditional code. It's simpler to use `import typing` and reference `typing.Iterable`, etc. * generator: Use pathlib.PurePath for configuration parameters * generator: Fix lint errors * generator: Move path conversion and dict/list conversion into client_support module * service: Fix parameter name in client_support * service: Update client_support to use type specialization constants (cherry picked from commit 6e0aedb)
bkeryan
requested review from
csjall,
dixonjoel,
mshafer-NI and
nstokes-nati
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this Pull Request accomplish?
Cherry-pick #931 into releases/2.1.