Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

packagegroup-ni-ptest-smoke: Remove unused ptests #748

Open
wants to merge 1 commit into
base: nilrt/master/kirkstone
Choose a base branch
from

Conversation

usercw88
Copy link
Contributor

@usercw88 usercw88 commented Oct 3, 2024

Summary of Changes

Removed ptests that were found to be unused - ptests that were executed, but did not run any tests

Justification

AB#2755352
The testptest.py will be updated to assert if a ptest does not return any test results

Testing

TODO: Detail what testing has been done to ensure this submission meets requirements.

  • I have built the core package feed with this PR in place. (bitbake packagefeed-ni-core)
  • I have built the core package feed with this PR in place. (bitbake packagegroup-ni-ptest-smoke)

Procedure

Signed-off-by: Can Wong <can.wong@ni.com>
@usercw88 usercw88 requested a review from jpautler October 8, 2024 12:32
@usercw88 usercw88 marked this pull request as ready for review October 10, 2024 14:38
@jpautler
Copy link
Contributor

Can you change the commit message to reflect that we are removing these ptests from the smoke test packagegroup because they do not report results using the standard ptest PASS/FAIL conventions and therefore our test framework is currently unable to parse individual test results from them? Also, can you remove the TODO in the Testing section and describe your testing?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants