nilrt.inc: Change PACKAGE_FEED_* to default assignment #752
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Locally-hosted package repositories are a longstanding NI Linux RT development pattern. While these can be trivially configured in /etc/opkg/ after installation, being able to customize the feed URLs in the base system image itself unlocks some unique automation possibilities. While nilrt/scripts/tests/test_nilrt-ptest.py presently implements a feed server (and rewriting the post-install opkg configuration accordingly), its implementation is tightly coupled to the needs of ptest execution. Instead, the nominal way to accomplish this should be in site.conf: set PACKAGE_FEED_URIS to point at the local server, and clear out PACKAGE_FEED_BASE_PATHS, because the "extra/" and "main/" subdirectory distinction does not exist at the level of developer bitbake runs, nor arguably should it. That's not presently possible because PACAKGE_FEED_URIS and PACKAGE_FEED_BASE_PATHS are assigned in the usual way (`=`) in nilrt.inc, overriding anything set in nilrt.inc. If we change nilrt.inc to only set default values, i.e. `?=`, then customizing them in site.conf works. Note that almost all other variables in nilrt.inc are already default-assigned. PACKAGE_FEED_ARCHS does not need to be customizing for this use case, but is also changed to default assignment for reasons of consistency. Signed-off-by: Richard Tollerton <rich.tollerton@ni.com>
|
Looking at this some more, I wonder if your approach to overriding the feed URI only failed because you were attempting to assign to the Does it instead satisfy your usecase to override the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Locally-hosted package repositories are a longstanding NI Linux RT development pattern. While these can be trivially configured in /etc/opkg/ after installation, being able to customize the feed URLs in the base system image itself unlocks some unique automation possibilities.
While nilrt/scripts/tests/test_nilrt-ptest.py presently implements a feed server (and rewriting the post-install opkg configuration accordingly), its implementation is tightly coupled to the needs of ptest execution. Instead, the nominal way to accomplish this should be in site.conf: set PACKAGE_FEED_URIS to point at the local server, and clear out PACKAGE_FEED_BASE_PATHS, because the "extra/" and "main/" subdirectory distinction does not exist at the level of developer bitbake runs, nor arguably should it.
That's not presently possible because PACAKGE_FEED_URIS and PACKAGE_FEED_BASE_PATHS are assigned in the usual way (
=) in nilrt.inc, overriding anything set in nilrt.inc. If we change nilrt.inc to only set default values, i.e.?=, then customizing them in site.conf works. Note that almost all other variables in nilrt.inc are already default-assigned.PACKAGE_FEED_ARCHS does not need to be customizing for this use case, but is also changed to default assignment for reasons of consistency.
Procedure