Fix Localize regression with empty default message #305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Behavior has changed with nicksnyder#189. Before that, an empty default message returned nil and an error, now it returns "" without error. This has been detected by mattermost test suit in mattermost/mattermost#21327 which tries to switch all code base to go-i18n v2, see https://github.com/mattermost/mattermost/pull/21327/files#r1365634307
Codecov Report
@@ Coverage Diff @@
## main #305 +/- ##
==========================================
+ Coverage 82.41% 82.46% +0.04%
==========================================
Files 15 15
Lines 1183 1186 +3
==========================================
+ Hits 975 978 +3
Misses 145 145
Partials 63 63
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
nicksnyder
reviewed
Oct 21, 2023
|
Thanks for the fix! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Behavior has changed with #189. Before that, an empty default message returned nil and an error, now it returns "" without error.
This has been detected by mattermost test suit in mattermost/mattermost#21327 which tries to switch all code base to go-i18n v2, see related discussion