Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handle 'on'/'off' and 'true'/'false' correctly #1626

Merged
merged 1 commit into from
Apr 24, 2016
Merged

Conversation

jasoncalabrese
Copy link
Member

Hoping this resolves #1605

@oamyoamy

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.02%) to 74.565% when pulling dbe29bd on wip/off-false-etc into 4da9d51 on dev.

@codecov-io
Copy link

Current coverage is 74.58%

Merging #1626 into dev will not affect coverage as of 4da9d51

@@              dev   #1626   diff @@
=====================================
  Files          94      94       
  Stmts        8225    8225       
  Branches        0       0       
  Methods         0       0       
=====================================
  Hit          6135    6135       
  Partial         0       0       
  Missed       2090    2090       

Review entire Coverage Diff as of 4da9d51


Uncovered Suggestions

  1. +0.28% via .../client/boluscalc.js#162...184
  2. +0.25% via .../client/boluscalc.js#303...322
  3. +0.22% via ...lugins/insulinage.js#73...90
  4. See 7 more...

Powered by Codecov. Updated on successful CI builds.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants