Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

display oref1 UAM purple line #2564

Merged
merged 1 commit into from
Jun 15, 2017
Merged

display oref1 UAM purple line #2564

merged 1 commit into from
Jun 15, 2017

Conversation

scottleibrand
Copy link
Member

Per openaps/oref0#424, the "oref1" features of openaps/oref0 now support unannounced meal predictions and dosing. This PR displays those predictions in Nightscout (alongside the other three OpenAPS purple line predictions) if a rig is generating them.

@alternateal
Copy link

This works well for me 👍

@Kdisimone
Copy link
Contributor

working well for me as well

@tim2000s
Copy link

tim2000s commented May 9, 2017

Works for me 👍

@PieterGit
Copy link
Contributor

Works well for me too. Perhaps making UAM line with filled dots will be even better. In most cases I've seen the UAM line is the most reliable BG estimate.

@scottleibrand
Copy link
Member Author

We've found that different estimates are more accurate in different situations, so I wouldn't want to visually prefer one over the others (although distinguishing them might be useful in some cases).

Any objections to merging?

@scottleibrand
Copy link
Member Author

Closing and reopening to force a new travis build.

@scottleibrand
Copy link
Member Author

Looks like the failure is:

not ok 224 reports should produce some html
AssertionError: expected -1 to be above -1
at Assertion.fail (node_modules/should/cjs/should.js:231:17)
at Assertion.value (node_modules/should/cjs/should.js:305:19)
at afterInit (tests/reports.test.js:269:172)
at authCallback (lib/client/index.js:9:56254)
at Object.mockEmit [as emit] (tests/fixtures/headless.js:136:19)
at lib/client/index.js:9:54851
at Object.mockOn [as on] (tests/fixtures/headless.js:131:19)
at Object.load (lib/client/index.js:9:54658)
at success (lib/client/index.js:9:3181)
at Object.mockDone [as done] (tests/fixtures/headless.js:64:19)
at Object.init (lib/client/index.js:9:2992)
at Context. (tests/reports.test.js:228:12)
at tests/fixtures/headless.js:150:7
at Object.module.exports.setup (node_modules/benv/index.js:24:56)
at Function.init [as setup] (tests/fixtures/headless.js:16:10)
at Context. (tests/reports.test.js:197:14)

Looks like that same failure is occurring on all other PRs as well, so it must've been caused by a recently merged commit, not anything we're doing here.

@scottleibrand scottleibrand merged commit 46c06e8 into dev Jun 15, 2017
@scottleibrand scottleibrand deleted the floating-carbs branch June 15, 2017 18:05
applehat added a commit to applehat/cgm-remote-monitor that referenced this pull request Jun 15, 2017
display floating carbs / UAM purple line (nightscout#2564)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants