Bewest/api/create entries #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is to help out with #35 |
|
I'd like to define the _id based on a hash of some key values to prevent storing duplicate values. I borrowed some code from tidepool for the api I added had in project-glu, https://github.com/jasoncalabrese/project-glu/blob/master/lib/models/entry.js#L31 Maybe something like that would work? With the current 2 day upload on startup we can upload lots of duplicate data. The _id hashing should probably happen in entities.js |
The api function now returns something useful in addition to doing a little bit of work. It used to do a little bit of work, now it returns the result.
Clean up and comment a bunch of code.
sulkaharo
pushed a commit
that referenced
this pull request
Aug 28, 2019
cominixo
pushed a commit
to cominixo/cgm-remote-monitor
that referenced
this pull request
Mar 1, 2021
cominixo
pushed a commit
to cominixo/cgm-remote-monitor
that referenced
this pull request
Mar 1, 2021
…ssue#40 Update version of Elixir to 1.9.3 and Erlang to 22.2 fixes nightscout#40
freddyyi
pushed a commit
to freddyyi/cgm-remote-monitor
that referenced
this pull request
Apr 22, 2022
Fixes an issue where treatment units were all rewritten on load, rega…
jamorham
referenced
this pull request
in jamorham/nightscout-vps
Dec 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sketching out creating entries.
What do you guys think?