Merging @bewest's wip/api-modules work #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rename a few things here and there to help clarify the situation. This change introduces use of express.Router( ), which provides the routing functions of express without the full app. This also shows an experiment observing the interaction betwen express( ) and express.Router( ). There are a few reasons for doing this: Using express.Router( ) allows introspecting existing routes. As a REST application, our content payloads should include URLs, links to other resources available from our API. As a bonus feature, it's often nice for a meta page to describe the links, status, and version available from this particular API. By far, the easiest way to implement this is to introspect the existing routes. Separating the code makes testing easier. This lays the ground work for breaking apart the code into smaller, more testable modules.
This avoids re-using the same variable name in different contexts.
Small hack in order to start separating things out a bit more.
Make as few adjustments as needed to get entries api into it's own module.
Also remove notion of common configured middleware.
brianhanifin
added a commit
that referenced
this pull request
Jul 18, 2014
Merging @bewest's wip/api-modules work
cominixo
pushed a commit
to cominixo/cgm-remote-monitor
that referenced
this pull request
Mar 1, 2021
…ack_issue#43 Create python script to update stack on all apps nightscout#43
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.