Revert "Fixing isShown: zero-size element should be invisible if it c…

…ontains a" This reverts commit f61d05c.
nimeacuerdo · Feb 25, 2013 · 0d43cd8 · 0d43cd8
1 parent f61d05c
commit 0d43cd8
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 12 deletions.
diff --git a/javascript/atoms/dom.js b/javascript/atoms/dom.js
@@ -692,7 +692,6 @@ bot.dom.isShown = function(elem, opt_ignoreOpacity) {
     // if they have a child element or text node with positive size.
     return goog.array.some(e.childNodes, function(n) {
       return (n.nodeType == goog.dom.NodeType.TEXT &&
-              bot.dom.trimExcludingNonBreakingSpaceCharacters_(n.nodeValue) != '' &&
               bot.dom.getEffectiveStyle(e, 'overflow') != 'hidden') ||
               (bot.dom.isElement(n) && positiveSize(n));
     });

diff --git a/javascript/atoms/test/shown_test.html b/javascript/atoms/test/shown_test.html
@@ -227,7 +227,7 @@
     }
 
     function testZeroSizedDivIsShownIfDescendantHasSize() {
-      if (goog.userAgent.IE && !bot.userAgent.isProductVersion(7)) {
+       if (goog.userAgent.IE && !bot.userAgent.isProductVersion(7)) {
        return;
       }
       var element = goog.dom.createDom('div', {id:"ZeroSizedDiv", style: 'width:0;height:0'},
@@ -415,14 +415,6 @@
       var child = findElement({id: "bug5140-3-child"});
       assertTrue(isShown(child));
     }
-
-    function testZeroSizedDivIsNotShownIfDescendantHasEmptyText() {
-      if (goog.userAgent.IE && !bot.userAgent.isProductVersion(7)) {
-       return;
-      }
-      var element = findElement({id: 'bug5220-invisible'});
-      assertFalse(isShown(element));
-    }
   </script>
 
   <style type="text/css">
@@ -615,7 +607,5 @@
 <div id='bug5140-1' style="overflow:hidden; height:0; width:0;"><div id='bug5140-1-child' style="height:25px; width:25px;">.</div></div>
 <div id='bug5140-2' style="overflow:hidden; height:50px; width:50px;"><div id='bug5140-2-child' style="height:25px; width:25px; margin:50px; background-color:red;">.</div></div>
 <div id='bug5140-3' style="overflow:hidden; height:50px; width:50px;"><div id='bug5140-3-child' style="height:25px; width:25px; margin:49px; background-color:red;">.</div></div>
-<div id='bug5220-invisible' style="height:0; width:0;"><a href="#">   
-   </a></div>
 </body>
 </html>