Unignoring tests that pass locally in Chrome

nimeacuerdo · Mar 16, 2013 · 6cfaf2b · 6cfaf2b
1 parent b99e016
commit 6cfaf2b
Show file tree

Hide file tree

Showing 11 changed files with 22 additions and 34 deletions.
diff --git a/java/client/test/org/openqa/selenium/ClearTest.java b/java/client/test/org/openqa/selenium/ClearTest.java
@@ -23,13 +23,12 @@
 import static org.junit.Assert.assertEquals;
 import static org.junit.Assert.fail;
 import static org.openqa.selenium.testing.Ignore.Driver.ANDROID;
-import static org.openqa.selenium.testing.Ignore.Driver.CHROME;
 import static org.openqa.selenium.testing.Ignore.Driver.IPHONE;
 import static org.openqa.selenium.testing.Ignore.Driver.OPERA;
 import static org.openqa.selenium.testing.Ignore.Driver.OPERA_MOBILE;
 import static org.openqa.selenium.testing.Ignore.Driver.SELENESE;
 
-@Ignore({CHROME, SELENESE, ANDROID})
+@Ignore({SELENESE, ANDROID})
 public class ClearTest extends JUnit4TestBase {
 
   @Test

diff --git a/java/client/test/org/openqa/selenium/ClickScrollingTest.java b/java/client/test/org/openqa/selenium/ClickScrollingTest.java
@@ -81,7 +81,6 @@ public void testShouldScrollToClickOnAnElementHiddenByOverflow() {
   }
 
   @Test
-  @Ignore(CHROME)
   public void testShouldBeAbleToClickOnAnElementHiddenByOverflow() {
     driver.get(appServer.whereIs("scroll.html"));
 
@@ -91,7 +90,7 @@ public void testShouldBeAbleToClickOnAnElementHiddenByOverflow() {
     assertEquals("line8", driver.findElement(By.id("clicked")).getText());
   }
 
-  @Ignore({CHROME, OPERA, SELENESE})
+  @Ignore({OPERA, SELENESE})
   @Test
   public void testShouldNotScrollOverflowElementsWhichAreVisible() {
     driver.get(appServer.whereIs("scroll2.html"));

diff --git a/java/client/test/org/openqa/selenium/ElementAttributeTest.java b/java/client/test/org/openqa/selenium/ElementAttributeTest.java
@@ -35,7 +35,6 @@
 import static org.junit.Assert.assertTrue;
 import static org.junit.Assert.fail;
 import static org.openqa.selenium.testing.Ignore.Driver.ANDROID;
-import static org.openqa.selenium.testing.Ignore.Driver.CHROME;
 import static org.openqa.selenium.testing.Ignore.Driver.IE;
 import static org.openqa.selenium.testing.Ignore.Driver.IPHONE;
 import static org.openqa.selenium.testing.Ignore.Driver.OPERA;
@@ -83,7 +82,7 @@ public void testShouldReturnEmptyAttributeValuesWhenPresentAndTheValueIsActually
     assertThat(body.getAttribute("style"), equalTo(""));
   }
 
-  @Ignore({CHROME, OPERA, IPHONE, ANDROID, SELENESE})
+  @Ignore({OPERA, IPHONE, ANDROID, SELENESE})
   @Test
   public void testShouldReturnTheValueOfTheDisabledAttributeAsNullIfNotSet() {
     driver.get(pages.formPage);
@@ -338,7 +337,7 @@ public void testCanRetrieveTheCurrentValueOfATextFormField_textArea() {
     assertEquals("hello world", element.getAttribute("value"));
   }
 
-  @Ignore({CHROME, OPERA, IPHONE, ANDROID, SELENESE})
+  @Ignore({OPERA, IPHONE, ANDROID, SELENESE})
   @Test
   public void testShouldReturnNullForNonPresentBooleanAttributes() {
     driver.get(pages.booleanAttributes);

diff --git a/java/client/test/org/openqa/selenium/ElementFindingTest.java b/java/client/test/org/openqa/selenium/ElementFindingTest.java
@@ -28,7 +28,6 @@
 import static org.junit.Assert.assertTrue;
 import static org.junit.Assert.fail;
 import static org.openqa.selenium.testing.Ignore.Driver.ANDROID;
-import static org.openqa.selenium.testing.Ignore.Driver.CHROME;
 import static org.openqa.selenium.testing.Ignore.Driver.IE;
 import static org.openqa.selenium.testing.Ignore.Driver.IPHONE;
 import static org.openqa.selenium.testing.Ignore.Driver.OPERA;
@@ -516,7 +515,6 @@ public void testShouldBeAbleToFindElementsByCssSelector() {
   }
 
   @JavascriptEnabled
-  @Ignore(CHROME)
   @Test
   public void testShouldBeAbleToFindAnElementByCompoundCssSelector() {
     driver.get(pages.xhtmlTestPage);
@@ -525,7 +523,6 @@ public void testShouldBeAbleToFindAnElementByCompoundCssSelector() {
   }
 
   @JavascriptEnabled
-  @Ignore(CHROME)
   @Test
   public void testShouldBeAbleToFindElementsByCompoundCssSelector() {
     driver.get(pages.xhtmlTestPage);
@@ -620,7 +617,7 @@ public void testAnElementFoundInADifferentFrameViaJsCanBeUsed() {
   }
 
   @Test
-  @Ignore({CHROME, OPERA})
+  @Ignore({OPERA})
   public void findsByLinkTextOnXhtmlPage() {
     if (isOldIe(driver)) {
       // Old IE doesn't render XHTML pages, don't try loading XHTML pages in it

diff --git a/java/client/test/org/openqa/selenium/ElementSelectingTest.java b/java/client/test/org/openqa/selenium/ElementSelectingTest.java
@@ -25,7 +25,6 @@
 import static org.junit.Assert.assertThat;
 import static org.junit.Assert.assertTrue;
 import static org.openqa.selenium.testing.Ignore.Driver.ANDROID;
-import static org.openqa.selenium.testing.Ignore.Driver.CHROME;
 import static org.openqa.selenium.testing.Ignore.Driver.OPERA_MOBILE;
 import static org.openqa.selenium.testing.Ignore.Driver.SELENESE;
 import static org.openqa.selenium.TestWaiter.waitFor;
@@ -113,7 +112,7 @@ public void testClickingOnASelectedRadioButtonShouldLeaveItSelected() {
     assertTrue(button.isSelected());
   }
 
-  @Ignore(value = {CHROME, SELENESE, ANDROID}, reason = "Android: opens a dialog.")
+  @Ignore(value = {SELENESE, ANDROID}, reason = "Android: opens a dialog.")
   @Test
   public void testShouldBeAbleToToggleEnabledMultiSelectOption() {
     driver.get(pages.formPage);

diff --git a/java/client/test/org/openqa/selenium/FrameSwitchingTest.java b/java/client/test/org/openqa/selenium/FrameSwitchingTest.java
@@ -37,7 +37,6 @@
 import static org.openqa.selenium.WaitingConditions.pageTitleToBe;
 import static org.openqa.selenium.testing.Ignore.Driver.ALL;
 import static org.openqa.selenium.testing.Ignore.Driver.ANDROID;
-import static org.openqa.selenium.testing.Ignore.Driver.CHROME;
 import static org.openqa.selenium.testing.Ignore.Driver.OPERA;
 import static org.openqa.selenium.testing.Ignore.Driver.OPERA_MOBILE;
 import static org.openqa.selenium.testing.Ignore.Driver.PHANTOMJS;
@@ -421,7 +420,7 @@ public void testShouldNotBeAbleToDoAnythingTheFrameIsDeletedFromUnderUs() {
     }
   }
 
-  @Ignore(value = {CHROME, SELENESE}, reason = "These drivers still return frame title.")
+  @Ignore(value = {SELENESE}, reason = "These drivers still return frame title.")
   @Test
   public void testShouldReturnWindowTitleInAFrameset() {
     driver.get(pages.framesetPage);

diff --git a/java/client/test/org/openqa/selenium/GetMultipleAttributeTest.java b/java/client/test/org/openqa/selenium/GetMultipleAttributeTest.java
@@ -24,14 +24,13 @@
 
 import static org.junit.Assert.assertEquals;
 import static org.openqa.selenium.testing.Ignore.Driver.ANDROID;
-import static org.openqa.selenium.testing.Ignore.Driver.CHROME;
 import static org.openqa.selenium.testing.Ignore.Driver.IPHONE;
 import static org.openqa.selenium.testing.Ignore.Driver.OPERA;
 import static org.openqa.selenium.testing.Ignore.Driver.SELENESE;
 
 public class GetMultipleAttributeTest extends JUnit4TestBase {
 
-  @Ignore({CHROME, OPERA, IPHONE, ANDROID, SELENESE})
+  @Ignore({OPERA, IPHONE, ANDROID, SELENESE})
   @Test
   public void testMultipleAttributeShouldBeNullWhenNotSet() {
     driver.get(pages.selectPage);

diff --git a/java/client/test/org/openqa/selenium/RenderedWebElementTest.java b/java/client/test/org/openqa/selenium/RenderedWebElementTest.java
@@ -51,7 +51,7 @@
 public class RenderedWebElementTest extends JUnit4TestBase {
 
   @JavascriptEnabled
-  @Ignore({ANDROID, CHROME, HTMLUNIT, OPERA, SELENESE})
+  @Ignore({ANDROID, HTMLUNIT, OPERA, SELENESE})
   @Test
   public void testShouldPickUpStyleOfAnElement() {
     driver.get(pages.javascriptPage);
@@ -68,7 +68,7 @@ public void testShouldPickUpStyleOfAnElement() {
   }
 
   @JavascriptEnabled
-  @Ignore({ANDROID, CHROME, HTMLUNIT, OPERA, SELENESE})
+  @Ignore({ANDROID, HTMLUNIT, OPERA, SELENESE})
   @Test
   public void testGetCssValueShouldReturnStandardizedColour() {
     driver.get(pages.colorPage);
@@ -266,7 +266,7 @@ public Boolean call() throws Exception {
 
   @JavascriptEnabled
   @Test
-  @Ignore({CHROME, OPERA, OPERA_MOBILE})
+  @Ignore({OPERA, OPERA_MOBILE})
   public void canClickOnASuckerFishStyleMenu() throws InterruptedException {
     assumeTrue(hasInputDevices());
     assumeTrue(TestUtilities.isNativeEventsEnabled(driver));
@@ -424,7 +424,7 @@ public void testMovingMouseToRelativeZeroElementOffset() {
 
   @JavascriptEnabled
   @NeedsFreshDriver
-  @Ignore(value = {CHROME, HTMLUNIT, SELENESE}, reason = "Advanced mouse actions only implemented in rendered browsers")
+  @Ignore(value = {HTMLUNIT, SELENESE}, reason = "Advanced mouse actions only implemented in rendered browsers")
   @Test
   public void testMoveRelativeToBody() {
     if (!hasInputDevices() || !TestUtilities.isNativeEventsEnabled(driver)) {

diff --git a/java/client/test/org/openqa/selenium/SelectElementHandlingTest.java b/java/client/test/org/openqa/selenium/SelectElementHandlingTest.java
@@ -23,7 +23,6 @@
 import static org.junit.Assert.assertThat;
 import static org.junit.Assert.assertTrue;
 import static org.openqa.selenium.testing.Ignore.Driver.ANDROID;
-import static org.openqa.selenium.testing.Ignore.Driver.CHROME;
 import static org.openqa.selenium.testing.Ignore.Driver.IPHONE;
 import static org.openqa.selenium.testing.Ignore.Driver.OPERA;
 import static org.openqa.selenium.testing.Ignore.Driver.SELENESE;
@@ -34,7 +33,7 @@
 
 public class SelectElementHandlingTest extends JUnit4TestBase {
 
-  @Ignore({CHROME, SELENESE, IPHONE, OPERA, ANDROID})
+  @Ignore({SELENESE, IPHONE, OPERA, ANDROID})
   @Test
   public void testShouldBePossibleToDeselectASingleOptionFromASelectWhichAllowsMultipleChoices() {
     driver.get(pages.formPage);
@@ -105,7 +104,7 @@ public void testShouldSelectFirstOptionByDefaultIfNoneIsSelected() {
     assertThat(two.isSelected(), is(true));
   }
 
-  @Ignore({SELENESE, CHROME})
+  @Ignore({SELENESE})
   @Test
   public void testCanSelectElementsInOptGroups() {
     driver.get(pages.selectPage);

diff --git a/java/client/test/org/openqa/selenium/TextHandlingTest.java b/java/client/test/org/openqa/selenium/TextHandlingTest.java
@@ -22,7 +22,6 @@
 import static org.junit.Assert.assertThat;
 import static org.junit.Assert.assertTrue;
 import static org.openqa.selenium.testing.Ignore.Driver.ANDROID;
-import static org.openqa.selenium.testing.Ignore.Driver.CHROME;
 import static org.openqa.selenium.testing.Ignore.Driver.HTMLUNIT;
 import static org.openqa.selenium.testing.Ignore.Driver.IE;
 import static org.openqa.selenium.testing.Ignore.Driver.IPHONE;
@@ -121,7 +120,7 @@ public void testShouldConvertANonBreakingSpaceIntoANormalSpaceCharacter() {
     assertThat(text, equalTo("This line has a non-breaking space"));
   }
 
-  @Ignore({CHROME, IPHONE, SELENESE})
+  @Ignore({IPHONE, SELENESE})
   @Test
   public void testShouldNotCollapseANonBreakingSpaces() {
     driver.get(pages.simpleTestPage);
@@ -131,7 +130,7 @@ public void testShouldNotCollapseANonBreakingSpaces() {
     assertThat(text, equalTo("This line has a   non-breaking space and spaces"));
   }
 
-  @Ignore({CHROME, IPHONE, SELENESE})
+  @Ignore({IPHONE, SELENESE})
   @Test
   public void testShouldNotTrimNonBreakingSpacesAtTheEndOfALineInTheMiddleOfText() {
     driver.get(pages.simpleTestPage);
@@ -140,7 +139,7 @@ public void testShouldNotTrimNonBreakingSpacesAtTheEndOfALineInTheMiddleOfText()
     assertThat(text, startsWith("These lines  \n"));
   }
 
-  @Ignore({CHROME, IPHONE, SELENESE})
+  @Ignore({IPHONE, SELENESE})
   @Test
   public void testShouldNotTrimNonBreakingSpacesAtTheStartOfALineInTheMiddleOfText() {
     driver.get(pages.simpleTestPage);
@@ -149,7 +148,7 @@ public void testShouldNotTrimNonBreakingSpacesAtTheStartOfALineInTheMiddleOfText
     assertThat(text, containsString("\n  have"));
   }
 
-  @Ignore({CHROME, IPHONE, SELENESE})
+  @Ignore({IPHONE, SELENESE})
   @Test
   public void testShouldNotTrimTrailingNonBreakingSpacesInMultilineText() {
     driver.get(pages.simpleTestPage);
@@ -176,7 +175,7 @@ public void testShouldReturnTheEntireTextOfInlineElements() {
     assertThat(text, equalTo("An inline element"));
   }
 
-  @Ignore({SELENESE, IPHONE, ANDROID, CHROME, OPERA})
+  @Ignore({SELENESE, IPHONE, ANDROID, OPERA})
   @Test
   public void testShouldRetainTheFormatingOfTextWithinAPreElement() {
     driver.get(pages.simpleTestPage);
@@ -188,7 +187,7 @@ public void testShouldRetainTheFormatingOfTextWithinAPreElement() {
         "         "));
   }
 
-  @Ignore({SELENESE, IPHONE, ANDROID, CHROME, OPERA})
+  @Ignore({SELENESE, IPHONE, ANDROID, OPERA})
   @Test
   public void testShouldRetainTheFormatingOfTextWithinAPreElementThatIsWithinARegularBlock() {
     driver.get(pages.simpleTestPage);
@@ -201,9 +200,8 @@ public void testShouldRetainTheFormatingOfTextWithinAPreElementThatIsWithinARegu
         "after pre"));
   }
 
-  @Ignore(value = {SELENESE, IPHONE, CHROME, IE, OPERA, OPERA_MOBILE}, reason =
+  @Ignore(value = {SELENESE, IPHONE, IE, OPERA, OPERA_MOBILE}, reason =
       "iPhone: sendKeys is broken;"
-      + " Chrome: not handling a space character properly."
       + " Opera,IE: inserts \r\n instead of \n.")
   @Test
   public void testShouldBeAbleToSetMoreThanOneLineOfTextInATextArea() {

diff --git a/java/client/test/org/openqa/selenium/WindowSwitchingTest.java b/java/client/test/org/openqa/selenium/WindowSwitchingTest.java
@@ -97,7 +97,7 @@ public void testShouldThrowNoSuchWindowException() {
     driver.switchTo().window(current);
   }
 
-  @Ignore({OPERA, CHROME, SELENESE, OPERA_MOBILE})
+  @Ignore({OPERA, SELENESE, OPERA_MOBILE})
   @Test
   public void testShouldThrowNoSuchWindowExceptionOnAnAttemptToGetItsHandle() {
     driver.get(pages.xhtmlTestPage);