Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dialing a peer sometime results in an error #447

Closed
jsdanielh opened this issue Nov 22, 2021 · 0 comments · Fixed by #448
Closed

Dialing a peer sometime results in an error #447

jsdanielh opened this issue Nov 22, 2021 · 0 comments · Fixed by #448
Assignees
@jsdanielh
Milestone
Nimiq 2.0 Devnet

Comments

@jsdanielh
Copy link
Member

Dialing a peer sometimes results in an error:

 2021-11-22 22:32:59.235 DEBUG behaviour            | Failed to dial peer 12D3KooWGckqX12JG7YWeR2mjD1RUFw1o77Cc34himkCL93PNEv4: DialPeerConditionFalse(Disconnected)
@jsdanielh jsdanielh self-assigned this Nov 22, 2021
jsdanielh added a commit that referenced this issue Nov 22, 2021
@jsdanielh
Fix incoming dial failure handling for connection pool behavior
33add48 
Fix incoming dial failure handling for connection pool behaviour.
Since the recent update of libp2p, [this
change](libp2p/rust-libp2p#2191) introduces
state to dial request that can be transmitted in
`inject_dial_failure`. So there are a couple of cases where the
function is called but we can ignore the error since the connection
is still to be completed or is already connected.

This fixes #447.
@jsdanielh jsdanielh mentioned this issue Nov 22, 2021
Merged
2 tasks
jsdanielh added a commit that referenced this issue Nov 22, 2021
@jsdanielh
Fix incoming dial failure handling for connection pool behavior
f72174a 
Fix incoming dial failure handling for connection pool behavior.
Since the recent update of libp2p, [this
change](libp2p/rust-libp2p#2191) introduces
state to dial request that can be transmitted in
`inject_dial_failure`. So there are a couple of cases where the
function is called but we can ignore the error since the connection
is still to be completed or is already connected.

This fixes #447.
@jsdanielh jsdanielh added this to the Nimiq 2.0 Devnet milestone Nov 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jsdanielh jsdanielh

Labels
None yet
Projects
None yet
Milestone
Nimiq 2.0 Devnet
Development

Successfully merging a pull request may close this issue.

Fix network issues nimiq/core-rs-albatross
1 participant
@jsdanielh