Core - Improve JavascriptObjectRepository.TryCallMethod Object Not Fo…

…und error message - Add method name and param count Resolves cefsharp#4209
ninjaxyh · Aug 21, 2022 · 2ead423 · 2ead423
1 parent 0131024
commit 2ead423
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 1 deletion.
diff --git a/CefSharp.Test/JavascriptBinding/JavaScriptObjectRepositoryFacts.cs b/CefSharp.Test/JavascriptBinding/JavaScriptObjectRepositoryFacts.cs
@@ -49,6 +49,16 @@ public void CanRegisterJavascriptObjectBindWhenNamespaceIsNull()
             Assert.Equal("ok", result.ReturnValue.ToString());
         }
 
+        [Fact]
+        public void ShouldReturnErrorMessageForObjectInvalidId()
+        {
+            IJavascriptObjectRepositoryInternal javascriptObjectRepository = new JavascriptObjectRepository();
+
+            var result = javascriptObjectRepository.TryCallMethod(100, "getExampleString", new object[0]);
+            Assert.False(result.Success);
+            Assert.StartsWith("Object Not Found Matching Id", result.Exception);
+        }
+
 #if !NETCOREAPP
         [Fact]
         public void CanRegisterJavascriptObjectPropertyBindWhenNamespaceIsNull()

diff --git a/CefSharp/Internals/JavascriptObjectRepository.cs b/CefSharp/Internals/JavascriptObjectRepository.cs
@@ -293,7 +293,9 @@ protected virtual TryCallMethodResult TryCallMethod(long objectId, string name,
 
             if (!objects.TryGetValue(objectId, out obj))
             {
-                return new TryCallMethodResult(false, result, "Object Not Found Matching Id:" + objectId);
+                var paramCount = parameters == null ? 0 : parameters.Length;
+
+                return new TryCallMethodResult(false, result, $"Object Not Found Matching Id:{objectId}, MethodName:{name}, ParamCount:{paramCount}");
             }
 
             var method = obj.Methods.FirstOrDefault(p => p.JavascriptName == name);