Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

small fix copyfile_input #415

Merged
merged 2 commits into from
Feb 17, 2021
Merged

small fix copyfile_input #415

merged 2 commits into from
Feb 17, 2021

Conversation

djarecka
Copy link
Collaborator

Acknowledgment

  • I acknowledge that this contribution will be available under the Apache 2 license.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Summary

  • adding MultiInputFile as a possible type to copyfile_input (accepting list as a field)
  • checking if the input is not NOTHING

Checklist

  • All tests passing
  • I have added tests to cover my changes
  • I have updated documentation (if necessary)
  • My code follows the code style of this project
    (we are using black: you can pip install pre-commit,
    run pre-commit install in the pydra directory
    and black will be run automatically with each commit)

@codecov
Copy link

codecov bot commented Feb 17, 2021

Codecov Report

Merging #415 (6e66484) into master (6177c68) will decrease coverage by 0.12%.
The diff coverage is 46.15%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #415      +/-   ##
==========================================
- Coverage   82.50%   82.37%   -0.13%     
==========================================
  Files          19       19              
  Lines        3847     3853       +6     
  Branches     1053     1055       +2     
==========================================
  Hits         3174     3174              
- Misses        483      488       +5     
- Partials      190      191       +1     
Flag Coverage Δ
unittests 82.29% <46.15%> (-0.13%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pydra/engine/helpers_file.py 78.20% <46.15%> (-1.66%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6177c68...6e66484. Read the comment docs.

@djarecka djarecka merged commit 9cfb441 into nipype:master Feb 17, 2021
@djarecka djarecka deleted the fix/copyfile branch December 30, 2022 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant