ENH: Allow attr_fields to exclude fields #426
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
effigies
force-pushed
the
enh/exclude_fields
branch
2 times, most recently
from
9cf9590
to
0b217c6
Compare
Codecov Report
@@ Coverage Diff @@
## master #426 +/- ##
==========================================
- Coverage 82.45% 82.39% -0.06%
==========================================
Files 19 19
Lines 3859 3846 -13
Branches 1054 1048 -6
==========================================
- Hits 3182 3169 -13
Misses 487 487
Partials 190 190
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
effigies
force-pushed
the
enh/exclude_fields
branch
from
0b217c6
to
c840917
Compare
djarecka
reviewed
Feb 22, 2021
| else: | ||
| raise Exception("not implemented (collect_additional_output)") | ||
| for fld in attr_fields(self, exclude_names=("return_code", "stdout", "stderr")): | ||
| if fld.type not in [ |
There was a problem hiding this comment.
i'm actually not sure if we should be checking this here.. but can think about this in a different pr
There was a problem hiding this comment.
Can you make an issue and expand on your reasoning here? I agree that we should keep this PR focused.
|
lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Acknowledgment
Types of changes
Summary
It is fairly common for calls to
attr_fieldsto be followed by a filter for specific names that get ignored. This adds an exclusion list to the call to simplify the loops.Checklist
(we are using
black: you canpip install pre-commit,run
pre-commit installin thepydradirectoryand
blackwill be run automatically with each commit)