Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding full traceback to the error files #430

Merged
merged 2 commits into from
Feb 26, 2021

Conversation

djarecka
Copy link
Collaborator

@djarecka djarecka commented Feb 25, 2021

Acknowledgment

  • I acknowledge that this contribution will be available under the Apache 2 license.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Summary

  • checking error tracebacks in the _run methods and saving it to the error file
  • adding info about the specific task's error file for wf error message
  • adding tests

Checklist

  • All tests passing
  • I have added tests to cover my changes
  • I have updated documentation (if necessary)
  • My code follows the code style of this project
    (we are using black: you can pip install pre-commit,
    run pre-commit install in the pydra directory
    and black will be run automatically with each commit)

@codecov
Copy link

codecov bot commented Feb 25, 2021

Codecov Report

Merging #430 (fe99b90) into master (d730edf) will increase coverage by 0.06%.
The diff coverage is 81.81%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #430      +/-   ##
==========================================
+ Coverage   82.33%   82.40%   +0.06%     
==========================================
  Files          19       20       +1     
  Lines        3832     3858      +26     
  Branches     1046     1049       +3     
==========================================
+ Hits         3155     3179      +24     
  Misses        487      487              
- Partials      190      192       +2     
Flag Coverage Δ
unittests 82.32% <81.81%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pydra/engine/helpers.py 78.58% <0.00%> (-0.20%) ⬇️
pydra/engine/core.py 88.22% <100.00%> (+0.09%) ⬆️
pydra/__init__.py 95.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d730edf...fe99b90. Read the comment docs.

@djarecka
Copy link
Collaborator Author

djarecka commented Feb 25, 2021

anyone knows how to fix the test so it works in windows?
edited:
done

@djarecka djarecka merged commit b934e4b into nipype:master Feb 26, 2021
@djarecka djarecka deleted the mnt/error_tb branch December 30, 2022 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant