Fix null/null repository URL
#106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On the latest version I started getting these errors in the logs and my jobs would trigger every minute and never flag the build as having run before. ``` POST state INPROGRESS to https://bitbucket.org/api/2.0/repositories/null/null/commit/b6f8169ce460/statuses/build with key 515f53a20bf37bd484f2be5cda6ab168cd194cee with response {"type": "error", "error": {"message": "Repository null/null not found"}} ``` Functionality in `getOwnerName` and `getRepositoryName` name changed from previous versions, moved to inside `setFullName` which is now doing the `if` on the wrong value. This causes `null/null` to be set as the owner name / repo name.
|
Made a patch fixing the NPE problem as well |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On the latest version I started getting these errors in the logs and my jobs would trigger every minute and never flag the build as having run before.
Functionality in
getOwnerNameandgetRepositoryNamename changed from previous versions, moved to insidesetFullNamewhich is now doing theifon the wrong value. This causesnull/nullto be set as the owner name / repo name.