Parameterize comment phrase to trigger a build #45
Conversation
|
Looks like this duplicates pull request #11, which mentions some conflicts. |
|
hi, I'm going to check all PRs and eventually merge them |
Defaults to prior "test this please", can be overridden in the job configuration.
nblair
force-pushed
the
parameterize-comment-build-trigger
branch
from
4a54863
to
96e6cb6
Compare
|
Rebase is finished. I don't have the access to the environment I originally developed this with, so I don't have a way to end to end test the changes, YMMV. |
|
I'll see what I can do to get tests passing. |
Refactor to move default value for commentTrigger to config.jelly. Handle special case in BitbucketBuildRepository where trigger field is null within unit tests (since BitbucketBuildTrigger can't be mocked or initialized in the test).
|
oops, sorry to admit that, but I need you to rebase your change again...looks like in the meantime some change introduce the conflict . Once you rebase it I'll immediately merge it, I promise! |
|
Ack, I merged with master to resolve the last conflicts. Would you rather a cherry pick my commits to a new branch and re-submit? Or can I merge with master again? |
|
@nblair it's up to you...what is easy & faster for you? ( the thing is there are many open PRs which I will process in near time and I don't want to bother you again and again with resolving conflicts) |
|
Merge was a lot easier than rebase, just pushed. |
|
thank you, @nblair for your help! |
This pull request makes the comment phrase to trigger a build part of the configuration.
Defaults to "test this please" for backwards compatibility.