Don't hard-code a target family of Unix #255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rust target specs actually support multiple target families, where just one needs to match, so we do too. Reverse the order of the comparison so it is more consistent: wanted before the target's single value or list.
Ericson2314
force-pushed
the
target-family
branch
from
e658553
to
2e7b3ad
Compare
|
The new logic should be backported into a |
Ericson2314
added a commit
to alamgu/alamgu
that referenced
this pull request
Aug 26, 2022
This we we can handle `target_family` deps without cheating.
13 tasks
|
(The tests passed locally) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rust target specs actually support multiple target families, where just
one needs to match, so we do too.
Reverse the order of the comparison so it is more consistent: wanted
before the target's single value or list.