Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(crate2nix): change version in Cargo.toml #270

Merged
merged 1 commit into from
Jan 7, 2023
Merged

chore(crate2nix): change version in Cargo.toml #270

merged 1 commit into from
Jan 7, 2023

Conversation

steveej
Copy link
Contributor

@steveej steveej commented Jan 7, 2023

this makes it easier which version of crate2nix is installed in any target environment. the intention of this change is to have the resulting commit tagged as 0.11.0-rc.3.

see #264

cc @Ericson2314

@Ericson2314 Ericson2314 changed the base branch from master to release/0.11 January 7, 2023 01:54
@Ericson2314
Copy link
Collaborator

oh oops thanks for that. I'll put on the right branch and tag a new one.

@steveej
Copy link
Contributor Author

steveej commented Jan 7, 2023

@Ericson2314 i think there's a regeneration step missing. currently testing locally and will push to this branch once i'm confident about it.

@Ericson2314
Copy link
Collaborator

Oh I just pushed to release/0.11. I guess we will be making RC 4! haha

@steveej
Copy link
Contributor Author

steveej commented Jan 7, 2023

@Ericson2314 yes. i'm confused now about the version on master still stating 0.10.0 in the manifest. should i base this PR on the release/0.11 to make the version adjustment for 0.11.0-rc.4?

@steveej
Copy link
Contributor Author

steveej commented Jan 7, 2023

@Ericson2314 yes. i'm confused now about the version on master still stating 0.10.0 in the manifest. should i base this PR on the release/0.11 to make the version adjustment for 0.11.0-rc.4?

i did the above. i think it's fine as it's pushed here and can be merged and tagged :-)

also, thanks for your response 🙏 🙌

@Ericson2314 Ericson2314 changed the base branch from release/0.11 to master January 7, 2023 03:38
@Ericson2314 Ericson2314 changed the base branch from master to release/0.11 January 7, 2023 03:38
@Ericson2314 Ericson2314 merged commit 0b9d4bc into nix-community:release/0.11 Jan 7, 2023
@steveej steveej deleted the patch-1 branch January 9, 2023 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants