Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(luks): add an example using keyFile options #302

Merged
merged 1 commit into from
Jul 23, 2023

Conversation

rogarb
Copy link
Contributor

@rogarb rogarb commented Jul 23, 2023

This adds keyFileOffset and keyFileSize options in example/complex.nix. It follows the discussion in #301.

I thought that adding a new example file for these options was a lot of noise for little result.

@Lassulus if you meant something else with "a new test", please put me on tracks, as I quickly checked the tests folder and couldn't think about something relevant I could add there.

@rogarb
Copy link
Contributor Author

rogarb commented Jul 23, 2023

Mmm it seems that I asked too many bytes to read from the keyfile. I should have checked lib/tests.nix more thoroughly. It should work now.

@Lassulus Lassulus merged commit 713eb78 into nix-community:master Jul 23, 2023
28 of 29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants