Fix #392 #393
Merged
Fix #392 #393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aldoborrero
previously approved these changes
Oct 3, 2023
There was a problem hiding this comment.
LGTM. Maybe as I said on #392 we could consider adding a check to isDerivation and avoid recursing in such instances as well.
|
I had that at one point, but checking for the presence of Ideally we would probably do whatever NixOS modules do to detect infinite recursion, but I can't be bothered to figure that out at this time lol. |
|
Hey it works for now. We can improve the code later if necessary 😉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements my proposal from #392