feat: add statix for nix linting #71

brianmcgee · 2023-01-19T16:19:13Z

No description provided.

aldoborrero

See pending comments.

Also, I think we should include a shortcut within nix/scripts.nix to run easily the tool, in the same way, we can do with , fmt.

The rest of the PR looks good enough to me.

nix/checks.nix

brianmcgee · 2023-01-20T15:18:27Z

Also, I think we should include a shortcut within nix/scripts.nix to run easily the tool, in the same way, we can do with , fmt.

A shortcut is not needed. Just run statix or nix flake check.

aldoborrero

LGTM

brianmcgee requested a review from aldoborrero January 19, 2023 16:19

brianmcgee force-pushed the feat/statix branch 5 times, most recently from 858c951 to 320f1dd Compare January 20, 2023 10:28

aldoborrero requested changes Jan 20, 2023

View reviewed changes

nix/checks.nix Outdated Show resolved Hide resolved

aldoborrero mentioned this pull request Jan 20, 2023

mkGeth is not compatible with nix-update #70

Closed

brianmcgee force-pushed the feat/statix branch from 320f1dd to 2e3a487 Compare January 20, 2023 15:16

brianmcgee requested a review from aldoborrero January 20, 2023 15:18

aldoborrero previously approved these changes Jan 20, 2023

View reviewed changes

brianmcgee dismissed aldoborrero’s stale review via 84c40f3 January 20, 2023 17:01

brianmcgee force-pushed the feat/statix branch from 2e3a487 to 84c40f3 Compare January 20, 2023 17:01

brianmcgee requested a review from aldoborrero January 20, 2023 17:01

feat: statix for nix linting

a948d6d

aldoborrero force-pushed the feat/statix branch from 84c40f3 to a948d6d Compare January 23, 2023 09:37

aldoborrero approved these changes Jan 23, 2023

View reviewed changes

aldoborrero merged commit 8291281 into main Jan 23, 2023

aldoborrero deleted the feat/statix branch January 23, 2023 09:40

Provide feedback