Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

home-manager: use short -f instead of --fqdn #5471

Merged
merged 1 commit into from
May 30, 2024

Conversation

gauravjuvekar
Copy link
Contributor

Description

MacOS doesn't support the long-style --fqdn option to hostname that
was added by 1b58925.

Switch to short style -f that should be supported on every platform.

Checklist

  • Change is backwards compatible.

  • Code formatted with ./format.

  • Code tested through nix-shell --pure tests -A run.all or nix develop --ignore-environment .#all using Flakes.

  • Test cases updated/added. See example.

  • Commit messages are formatted like

    {component}: {description}
    
    {long description}
    

    See CONTRIBUTING for more information and recent commit messages for examples.

  • If this PR adds a new module

    • Added myself as module maintainer. See example.

Maintainer CC

MacOS doesn't support the long-style `--fqdn` option to `hostname` that
was added by 1b58925.

Switch to short style `-f` that should be supported on every platform.
@rycee rycee merged commit 0eb314b into nix-community:master May 30, 2024
3 checks passed
@rycee
Copy link
Member

rycee commented May 30, 2024

Thanks for the quick fix. Merged now 🙂

@ilyagr
Copy link

ilyagr commented May 30, 2024

Thank you very much!

Just FYI, on Mac OS, hostname -f seems to be the same as hostname. See e.g. https://man.freebsd.org/cgi/man.cgi?hostname(1) .

@gauravjuvekar gauravjuvekar deleted the fqdn branch May 31, 2024 04:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants