librewolf: use mkFirefoxModule #5684
Conversation
|
Bookmarks don't appear to work, so they should probably be turned off somehow. programs.librewolf.profiles.default.bookmarks = [{
name = "bookmarklets";
toolbar = true;
bookmarks = [
{
name = "example.com";
url = "https://example.com";
}
];
}];I vaguely recall someone mentioning this somewhere. |
This is temporary until mkFirefoxModule is added to the programs.librewolf module: nix-community/home-manager#5684
This is temporary until mkFirefoxModule is added to the programs.librewolf module: nix-community/home-manager#5684
|
Yea I had shared the same experience with bookmarks in #5128 (comment), but removed it in a later edit of the message. The option could be marked as |
|
Looks great otherwise! |
|
why does it not work though? it doesn't look like librewolf patches out any bookmark-related code |
There was a problem hiding this comment.
Nice to see this finally be a feature. From my initial testing everything works as expected.
For anyone else trying this out, the default search engine won't change in v128 unless you patch #5685 in your fork as well.
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/librewolf-kde-integration-not-working/50464/6 |
modules/programs/librewolf.nix
Outdated
| name = "LibreWolf"; | ||
| wrappedPackageName = "librewolf"; | ||
| unwrappedPackageName = "librewolf-unwrapped"; | ||
| visible = true; |
There was a problem hiding this comment.
| visible = true; |
I would probably unset visible, because otherwise it makes the generic Firefox options appear twice in the generated documentation.
There was a problem hiding this comment.
that seems fine to me, that's how it works in nixpkgs, are the home-manager docs conventions different?
There was a problem hiding this comment.
I don't know about the conventions, but that's how the chromite module does it. It also hides generic options for its derivatives.
| imports = [ | ||
| (mkFirefoxModule { | ||
| inherit modulePath; | ||
| name = "LibreWolf"; |
There was a problem hiding this comment.
| name = "LibreWolf"; | |
| name = "LibreWolf"; | |
| description = "LibreWolf is a privacy enhanced Firefox fork."; |
Optionally include the original description.
|
How would this implement nativeMessagingHosts and how could i use this for that when this gets merged? |
|
It's implemented in the underlying Custom native messaging hosts can be added using |
There was a problem hiding this comment.
Been using this and #5685 for a couple of days now, and it's been working very well.
|
Is it normal for the tests to take this long? It seems to me like they have said "Waiting for status to be reported" since the beginning of last month. |
|
Hey @chayleaf, in case you aren't busy, could you take a look at my latest review? This way we would give the tests a rerun. |
|
These tests sure take long. Perhaps they haven't started yet because of GitHub limits? |
|
I don't think these tests are going to finish anytime soon, is there something wrong with them? Or is there any possibility of running them locally if that will help. |
|
The tests won't run until the workflow is approved. |
Description
Checklist
Change is backwards compatible.
Code formatted with
./format.Code tested through
nix-shell --pure tests -A run.allornix develop --ignore-environment .#allusing Flakes.Test cases updated/added. See example.
Commit messages are formatted like
See CONTRIBUTING for more information and recent commit messages for examples.
If this PR adds a new module
Maintainer CC
@onny