Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hash function without allocation #2269

Merged
merged 5 commits into from
Jul 17, 2020
Merged

Hash function without allocation #2269

merged 5 commits into from
Jul 17, 2020

Conversation

nlohmann
Copy link
Owner

This PR replaces the naive std::hash specialization that hashed the result of json::dump via std::hash<std::string>.

@nlohmann nlohmann marked this pull request as draft July 14, 2020 12:33
@nlohmann nlohmann mentioned this pull request Jul 14, 2020
Closed
4 tasks
@coveralls
Copy link

coveralls commented Jul 14, 2020 •
edited
Loading

Coverage Status

Coverage remained the same at 100.0% when pulling b821ed0 on hash into 1a521cb on develop.

@nlohmann nlohmann marked this pull request as ready for review July 15, 2020 11:46
@nlohmann nlohmann added this to the Release 3.8.1 milestone Jul 15, 2020
@nlohmann nlohmann self-assigned this Jul 15, 2020
@nlohmann nlohmann merged commit 270f1ae into develop Jul 17, 2020
@nlohmann nlohmann deleted the hash branch July 17, 2020 11:57
@nlohmann
Copy link
Owner Author

🔖 Release item

This issue/PR will be part of the next release of the library. This template helps preparing the release notes.

Type

  • ✨ New Feature
  • 🐛 Bug Fix
  • ⚡️ Improvement
  • 🔨 Further Change
  • 🔥 Deprecated function

Description

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@nlohmann nlohmann

Labels
release item: ⚡ improvement
Projects
None yet
Milestone
Release 3.9.0
Development

Successfully merging this pull request may close these issues.
2 participants
@nlohmann @coveralls