Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove std::pair support #615

Merged
merged 1 commit into from
Jun 16, 2017
Merged

remove std::pair support #615

merged 1 commit into from
Jun 16, 2017

Conversation

theodelrieu
Copy link
Contributor

As stated in #614, I believe the std::pair support I introduced in #609 is bogus. How a pair should be represented is dependent of context, so I think it is wiser to remove it, and leave the question open.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.002%) to 99.72% when pulling c983648 on theodelrieu:develop into fd4a0ec on nlohmann:develop.

@theodelrieu
Copy link
Contributor Author

@nlohmann Do you know which line got uncovered? I failed to see which ones could be related to my changes

@gregmarr
Copy link
Contributor

@theodelrieu My guess is that because you removed covered lines, the percentage covered/total decreased. Say for example it was 7/10, and you removed two lines, it is now 5/8.

@nlohmann nlohmann merged commit d415293 into nlohmann:develop Jun 16, 2017
@nlohmann
Copy link
Owner

Thanks! We shall continue discussing #614. I also reopened #600. I am sure we will find a good solution for all this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants