Skip to content

Commit

Permalink
[FIX] packaging: avoid traceback on virtual machine timeout
Browse files Browse the repository at this point in the history
When the virtual machine used to build MS Win package takes too much
time (to build or to test the build), a warning is logged and the VM is killed.

Before this commit, the PID of the process was passed as an argument to
the warning method, causing a traceback.
  • Loading branch information
d-fence committed May 4, 2018
1 parent b0c08a6 commit 7202205
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion setup/package.py
Original file line number Diff line number Diff line change
Expand Up @@ -181,7 +181,7 @@ def __init__(self, o, image, ssh_key='', login='openerp'):
self.login = login

def timeout(self,signum,frame):
logging.warning("vm timeout kill",self.pid)
logging.warning("vm timeout kill (pid: {})".format(self.pid))
os.kill(self.pid,15)

def start(self):
Expand Down

0 comments on commit 7202205

Please sign in to comment.